mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
Auto merge of #18423 - emilio:more-stale-todos, r=nox
More stale todos Just removing or rewording stale stuff. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18423) <!-- Reviewable:end -->
This commit is contained in:
commit
8065eac0eb
3 changed files with 14 additions and 19 deletions
|
@ -419,17 +419,15 @@ impl PropertyAnimation {
|
|||
/// Inserts transitions into the queue of running animations as applicable for
|
||||
/// the given style difference. This is called from the layout worker threads.
|
||||
/// Returns true if any animations were kicked off and false otherwise.
|
||||
//
|
||||
// TODO(emilio): Take rid of this mutex splitting SharedLayoutContex into a
|
||||
// cloneable part and a non-cloneable part..
|
||||
#[cfg(feature = "servo")]
|
||||
pub fn start_transitions_if_applicable(new_animations_sender: &Sender<Animation>,
|
||||
pub fn start_transitions_if_applicable(
|
||||
new_animations_sender: &Sender<Animation>,
|
||||
opaque_node: OpaqueNode,
|
||||
old_style: &ComputedValues,
|
||||
new_style: &mut Arc<ComputedValues>,
|
||||
timer: &Timer,
|
||||
possibly_expired_animations: &[PropertyAnimation])
|
||||
-> bool {
|
||||
possibly_expired_animations: &[PropertyAnimation]
|
||||
) -> bool {
|
||||
let mut had_animations = false;
|
||||
for i in 0..new_style.get_box().transition_property_count() {
|
||||
// Create any property animations, if applicable.
|
||||
|
|
|
@ -88,13 +88,14 @@ impl<E: TElement> PushedElement<E> {
|
|||
fn new(el: E, num_hashes: usize) -> Self {
|
||||
PushedElement {
|
||||
element: unsafe { SendElement::new(el) },
|
||||
num_hashes: num_hashes,
|
||||
num_hashes,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn each_relevant_element_hash<E, F>(element: E, mut f: F)
|
||||
where E: TElement,
|
||||
where
|
||||
E: TElement,
|
||||
F: FnMut(u32),
|
||||
{
|
||||
f(element.get_local_name().get_hash());
|
||||
|
@ -104,10 +105,6 @@ fn each_relevant_element_hash<E, F>(element: E, mut f: F)
|
|||
f(id.get_hash());
|
||||
}
|
||||
|
||||
// TODO: case-sensitivity depends on the document type and quirks mode.
|
||||
//
|
||||
// TODO(emilio): It's not clear whether that's relevant here though?
|
||||
// Classes and ids should be normalized already I think.
|
||||
element.each_class(|class| {
|
||||
f(class.get_hash())
|
||||
});
|
||||
|
|
|
@ -53,8 +53,8 @@ impl InvalidationScope {
|
|||
|
||||
/// A set of invalidations due to stylesheet additions.
|
||||
///
|
||||
/// TODO(emilio): We might be able to do the same analysis for removals and
|
||||
/// media query changes too?
|
||||
/// TODO(emilio): We might be able to do the same analysis for media query
|
||||
/// changes too (or even selector changes?).
|
||||
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
|
||||
pub struct StylesheetInvalidationSet {
|
||||
/// The style scopes we know we have to restyle so far.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue