mirror of
https://github.com/servo/servo.git
synced 2025-09-30 08:39:16 +01:00
Auto merge of #17284 - jyc:custom-properties-cascade, r=emilio
Propagate changes in custom properties' computed values to descendants If ComputedValues.custom_properties differs between the old and new ComputedValues, indicate that we have to propogate changes to descendants by setting child_cascade_requirement to MustCascadeDescendants in cascade_primary. style::matching::TElement::cascade_primary already calls accumulate_damage, which eventually calls ServoRestyleDamage::compute_style_difference in order to check if other properties' computed values changed. If any of those change, we signal that we need to propogate changes for inherited properties. With Properties & Values, some custom properties will not be inherited, and we will need to revisit this. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17283 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17284) <!-- Reviewable:end -->
This commit is contained in:
commit
81275234aa
5 changed files with 57 additions and 2 deletions
|
@ -20015,6 +20015,12 @@
|
|||
{}
|
||||
]
|
||||
],
|
||||
"mozilla/upstream/css_variables_setProperty_recompute.html": [
|
||||
[
|
||||
"/_mozilla/mozilla/upstream/css_variables_setProperty_recompute.html",
|
||||
{}
|
||||
]
|
||||
],
|
||||
"mozilla/variadic-interface.html": [
|
||||
[
|
||||
"/_mozilla/mozilla/variadic-interface.html",
|
||||
|
@ -31700,6 +31706,10 @@
|
|||
"dfb31d3f9c4f24913055924c375f08b990b63e49",
|
||||
"testharness"
|
||||
],
|
||||
"mozilla/upstream/css_variables_setProperty_recompute.html": [
|
||||
"2e9326948f5115b3b63564fd26bae326bc8e2187",
|
||||
"testharness"
|
||||
],
|
||||
"mozilla/variadic-interface.html": [
|
||||
"9edd5150d36fabae42077a034655a8457eb75bff",
|
||||
"testharness"
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue