Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 14:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Add a note regarding why we don't need to handle percentages here.

Browse source
This commit is contained in:
Emilio Cobos Álvarez 2017-03-27 02:07:51 +02:00
parent fc72f096a0
commit 8175bfd60b
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/style/values/specified/length.rs
View file

@ -910,12 +910,24 @@ impl ToCss for CalcLengthOrPercentage {
/// A percentage value. /// A percentage value.
/// ///
/// [0 .. 100%] maps to [0.0 .. 1.0] /// [0 .. 100%] maps to [0.0 .. 1.0]
///
/// FIXME(emilio): There's no standard property that requires a `<percentage>`
/// without requiring also a `<length>`. If such a property existed, we'd need
/// to add special handling for `calc()` and percentages in here in the same way
/// as for `Angle` and `Time`, but the lack of this this is otherwise
/// undistinguishable (we handle it correctly from `CalcLengthOrPercentage`).
///
/// As of today, only `-moz-image-rect` supports percentages without length.
/// This is not a regression, and that's a non-standard extension anyway, so I'm
/// not implementing it for now.
#[derive(Clone, PartialEq, Copy, Debug)] #[derive(Clone, PartialEq, Copy, Debug)]
#[cfg_attr(feature = "servo", derive(HeapSizeOf))] #[cfg_attr(feature = "servo", derive(HeapSizeOf))]
pub struct Percentage(pub CSSFloat); pub struct Percentage(pub CSSFloat);
impl ToCss for Percentage { impl ToCss for Percentage {
fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write { fn to_css<W>(&self, dest: &mut W) -> fmt::Result
where W: fmt::Write,
{
write!(dest, "{}%", self.0 * 100.) write!(dest, "{}%", self.0 * 100.)
} }
} }