Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #8447 - frewsxcv:htmltableelement-width-idl-attribute, r=eefriedman

Browse source 
Implement 'width' IDL attribute on <table>

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8447)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-11-10 12:54:30 +05:30
commit 81f094b129
4 changed files with 7 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/htmltableelement.rs
View file

@ -115,6 +115,12 @@ impl HTMLTableElementMethods for HTMLTableElement {
// https://html.spec.whatwg.org/multipage/#dom-table-bgcolor // https://html.spec.whatwg.org/multipage/#dom-table-bgcolor
make_setter!(SetBgColor, "bgcolor"); make_setter!(SetBgColor, "bgcolor");
// https://html.spec.whatwg.org/multipage/#dom-table-width
make_getter!(Width);
// https://html.spec.whatwg.org/multipage/#dom-table-width
make_dimension_setter!(SetWidth, "width");
} }
pub trait HTMLTableElementLayoutHelpers { pub trait HTMLTableElementLayoutHelpers {

2
components/script/dom/webidls/HTMLTableElement.webidl
View file

@ -32,7 +32,7 @@ partial interface HTMLTableElement {
// attribute DOMString frame; // attribute DOMString frame;
// attribute DOMString rules; // attribute DOMString rules;
// attribute DOMString summary; // attribute DOMString summary;
// attribute DOMString width; attribute DOMString width;
[TreatNullAs=EmptyString] attribute DOMString bgColor; [TreatNullAs=EmptyString] attribute DOMString bgColor;
//[TreatNullAs=EmptyString] attribute DOMString cellPadding; //[TreatNullAs=EmptyString] attribute DOMString cellPadding;

6
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -4458,9 +4458,6 @@
[HTMLTableElement interface: attribute summary] [HTMLTableElement interface: attribute summary]
expected: FAIL expected: FAIL
[HTMLTableElement interface: attribute width]
expected: FAIL
[HTMLTableElement interface: attribute cellPadding] [HTMLTableElement interface: attribute cellPadding]
expected: FAIL expected: FAIL
@ -4524,9 +4521,6 @@
[HTMLTableElement interface: document.createElement("table") must inherit property "summary" with the proper type (20)] [HTMLTableElement interface: document.createElement("table") must inherit property "summary" with the proper type (20)]
expected: FAIL expected: FAIL
[HTMLTableElement interface: document.createElement("table") must inherit property "width" with the proper type (21)]
expected: FAIL
[HTMLTableElement interface: document.createElement("table") must inherit property "cellPadding" with the proper type (23)] [HTMLTableElement interface: document.createElement("table") must inherit property "cellPadding" with the proper type (23)]
expected: FAIL expected: FAIL

129
tests/wpt/metadata/html/dom/reflection-tabular.html.ini
View file

@ -1212,135 +1212,6 @@
[table.summary: IDL set to object "test-valueOf" followed by IDL get] [table.summary: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL expected: FAIL
[table.width: typeof IDL attribute]
expected: FAIL
[table.width: IDL get with DOM attribute unset]
expected: FAIL
[table.width: setAttribute() to "" followed by IDL get]
expected: FAIL
[table.width: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by IDL get]
expected: FAIL
[table.width: setAttribute() to undefined followed by IDL get]
expected: FAIL
[table.width: setAttribute() to 7 followed by IDL get]
expected: FAIL
[table.width: setAttribute() to 1.5 followed by IDL get]
expected: FAIL
[table.width: setAttribute() to true followed by IDL get]
expected: FAIL
[table.width: setAttribute() to false followed by IDL get]
expected: FAIL
[table.width: setAttribute() to object "[object Object\]" followed by IDL get]
expected: FAIL
[table.width: setAttribute() to NaN followed by IDL get]
expected: FAIL
[table.width: setAttribute() to Infinity followed by IDL get]
expected: FAIL
[table.width: setAttribute() to -Infinity followed by IDL get]
expected: FAIL
[table.width: setAttribute() to "\\0" followed by IDL get]
expected: FAIL
[table.width: setAttribute() to null followed by IDL get]
expected: FAIL
[table.width: setAttribute() to object "test-toString" followed by IDL get]
expected: FAIL
[table.width: setAttribute() to object "test-valueOf" followed by IDL get]
expected: FAIL
[table.width: IDL set to "" followed by getAttribute()]
expected: FAIL
[table.width: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by getAttribute()]
expected: FAIL
[table.width: IDL set to undefined followed by getAttribute()]
expected: FAIL
[table.width: IDL set to undefined followed by IDL get]
expected: FAIL
[table.width: IDL set to 7 followed by getAttribute()]
expected: FAIL
[table.width: IDL set to 7 followed by IDL get]
expected: FAIL
[table.width: IDL set to 1.5 followed by getAttribute()]
expected: FAIL
[table.width: IDL set to 1.5 followed by IDL get]
expected: FAIL
[table.width: IDL set to true followed by getAttribute()]
expected: FAIL
[table.width: IDL set to true followed by IDL get]
expected: FAIL
[table.width: IDL set to false followed by getAttribute()]
expected: FAIL
[table.width: IDL set to false followed by IDL get]
expected: FAIL
[table.width: IDL set to object "[object Object\]" followed by getAttribute()]
expected: FAIL
[table.width: IDL set to object "[object Object\]" followed by IDL get]
expected: FAIL
[table.width: IDL set to NaN followed by getAttribute()]
expected: FAIL
[table.width: IDL set to NaN followed by IDL get]
expected: FAIL
[table.width: IDL set to Infinity followed by getAttribute()]
expected: FAIL
[table.width: IDL set to Infinity followed by IDL get]
expected: FAIL
[table.width: IDL set to -Infinity followed by getAttribute()]
expected: FAIL
[table.width: IDL set to -Infinity followed by IDL get]
expected: FAIL
[table.width: IDL set to "\\0" followed by getAttribute()]
expected: FAIL
[table.width: IDL set to null followed by getAttribute()]
expected: FAIL
[table.width: IDL set to null followed by IDL get]
expected: FAIL
[table.width: IDL set to object "test-toString" followed by getAttribute()]
expected: FAIL
[table.width: IDL set to object "test-toString" followed by IDL get]
expected: FAIL
[table.width: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL
[table.cellPadding: typeof IDL attribute] [table.cellPadding: typeof IDL attribute]
expected: FAIL expected: FAIL