From 827261ab03ad47a926cd0d65bbd4412bca175458 Mon Sep 17 00:00:00 2001 From: Euclid Ye Date: Thu, 10 Jul 2025 20:54:46 +0800 Subject: [PATCH] Chore: cleanup unused `EmbedderMsg::WebDriverCommand` (#37979) Also fix doc for `WebDriverCommandMsg::GetWindowRect`. Testing: No behaviour change. Signed-off-by: Euclid Ye --- components/constellation/tracing.rs | 1 - components/servo/lib.rs | 1 - components/shared/embedder/lib.rs | 1 - components/shared/embedder/webdriver.rs | 2 +- 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/components/constellation/tracing.rs b/components/constellation/tracing.rs index d7bc03595ab..e4b68a6a1c4 100644 --- a/components/constellation/tracing.rs +++ b/components/constellation/tracing.rs @@ -246,7 +246,6 @@ mod from_script { Self::FinishJavaScriptEvaluation(..) => { target_variant!("FinishJavaScriptEvaluation") }, - Self::WebDriverCommand(..) => target_variant!("WebDriverCommand"), } } } diff --git a/components/servo/lib.rs b/components/servo/lib.rs index 3b9be5bc011..584d5902540 100644 --- a/components/servo/lib.rs +++ b/components/servo/lib.rs @@ -998,7 +998,6 @@ impl Servo { webview.delegate().show_form_control(webview, form_control); } }, - _ => {}, } } diff --git a/components/shared/embedder/lib.rs b/components/shared/embedder/lib.rs index c0561aa6add..da9b2369c45 100644 --- a/components/shared/embedder/lib.rs +++ b/components/shared/embedder/lib.rs @@ -425,7 +425,6 @@ pub enum EmbedderMsg { JavaScriptEvaluationId, Result, ), - WebDriverCommand(WebDriverCommandMsg), } impl Debug for EmbedderMsg { diff --git a/components/shared/embedder/webdriver.rs b/components/shared/embedder/webdriver.rs index edb72929e2a..9ffd187706f 100644 --- a/components/shared/embedder/webdriver.rs +++ b/components/shared/embedder/webdriver.rs @@ -40,7 +40,7 @@ pub enum WebDriverCommandMsg { /// Used in the initialization of the WebDriver server to set the sender for sending responses /// back to the WebDriver client. It is set to constellation for now SetWebDriverResponseSender(IpcSender), - /// Get the window size. + /// Get the window rectangle. GetWindowRect(WebViewId, IpcSender), /// Get the viewport size. GetViewportSize(WebViewId, IpcSender>),