Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 14:53:49 +01:00
Code Issues Projects Releases Packages Wiki Activity

GC hazard fix in document.rs (#34020)

Browse source 
Signed-off-by: L Ashwin B <lashwinib@gmail.com>
This commit is contained in:
chickenleaf 2024-10-26 18:52:10 +05:30 • committed by GitHub
parent 867510b9d8
commit 82c9d41330
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

30
components/script/dom/document.rs
View file

@ -4469,28 +4469,28 @@ impl DocumentMethods for Document {
let ns = namespace_from_domstring(maybe_ns); let ns = namespace_from_domstring(maybe_ns);
let local = LocalName::from(tag_name); let local = LocalName::from(tag_name);
let qname = QualName::new(None, ns, local); let qname = QualName::new(None, ns, local);
match self.tagns_map.borrow_mut().entry(qname.clone()) { if let Some(collection) = self.tagns_map.borrow().get(&qname) {
Occupied(entry) => DomRoot::from_ref(entry.get()), return DomRoot::from_ref(collection);
Vacant(entry) => {
let result = HTMLCollection::by_qual_tag_name(&self.window, self.upcast(), qname);
entry.insert(Dom::from_ref(&*result));
result
},
} }
let result = HTMLCollection::by_qual_tag_name(&self.window, self.upcast(), qname.clone());
self.tagns_map
.borrow_mut()
.insert(qname, Dom::from_ref(&*result));
result
} }
// https://dom.spec.whatwg.org/#dom-document-getelementsbyclassname // https://dom.spec.whatwg.org/#dom-document-getelementsbyclassname
fn GetElementsByClassName(&self, classes: DOMString) -> DomRoot<HTMLCollection> { fn GetElementsByClassName(&self, classes: DOMString) -> DomRoot<HTMLCollection> {
let class_atoms: Vec<Atom> = split_html_space_chars(&classes).map(Atom::from).collect(); let class_atoms: Vec<Atom> = split_html_space_chars(&classes).map(Atom::from).collect();
match self.classes_map.borrow_mut().entry(class_atoms.clone()) { if let Some(collection) = self.classes_map.borrow().get(&class_atoms) {
Occupied(entry) => DomRoot::from_ref(entry.get()), return DomRoot::from_ref(collection);
Vacant(entry) => {
let result =
HTMLCollection::by_atomic_class_name(&self.window, self.upcast(), class_atoms);
entry.insert(Dom::from_ref(&*result));
result
},
} }
let result =
HTMLCollection::by_atomic_class_name(&self.window, self.upcast(), class_atoms.clone());
self.classes_map
.borrow_mut()
.insert(class_atoms, Dom::from_ref(&*result));
result
} }
// https://dom.spec.whatwg.org/#dom-nonelementparentnode-getelementbyid // https://dom.spec.whatwg.org/#dom-nonelementparentnode-getelementbyid