From 82c9f9b84b33c74018ee8cb05d612be2c248c67c Mon Sep 17 00:00:00 2001 From: Brian Anderson Date: Tue, 21 Aug 2012 14:19:21 -0700 Subject: [PATCH] Reuse existing reference images --- src/reftest/reftest.rs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/reftest/reftest.rs b/src/reftest/reftest.rs index a60a60ac153..b61cda2bc8d 100644 --- a/src/reftest/reftest.rs +++ b/src/reftest/reftest.rs @@ -67,7 +67,7 @@ fn run_test(config: Config, file: ~str) { let servo_render = render_servo(config, file); let ref_render = render_ref(config, file); if servo_render != ref_render { - fail ~"rendered pages to not match"; + fail ~"rendered pages do not match"; } } @@ -86,9 +86,13 @@ fn render_servo(config: Config, file: ~str) -> Render { fn render_ref(config: Config, file: ~str) -> Render { let infile = file; let outfile = connect(config.work_dir, basename(file) + ".ref.png"); - let rasterize_path = rasterize_path(config); - let prog = run::start_program("python", ~[rasterize_path, infile, outfile]); - prog.finish(); + // After we've generated the reference image once, we don't need + // to keep launching Firefox + if !os::path_exists(outfile) { + let rasterize_path = rasterize_path(config); + let prog = run::start_program("python", ~[rasterize_path, infile, outfile]); + prog.finish(); + } return sanitize_image(outfile); }