Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Pass the correct argument to Element::create when cloning.

Browse source 
The current code calls as_slice() on the Option, yielding &[DOMString], and
then calls to_string, yielding "[prefix]".
This commit is contained in:
Ms2ger 2014-10-30 14:27:15 +01:00
parent 026b5e34ea
commit 82ff32a710
3 changed files with 1 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/node.rs
View file

@ -1516,7 +1516,7 @@ impl Node {
local: element.local_name().clone()
};
let element = Element::create(name,
Some(element.prefix().as_slice().to_string()), *document, ScriptCreated);
element.prefix().as_ref().map(|p| p.as_slice().to_string()), *document, ScriptCreated);
NodeCast::from_temporary(element)
},
TextNodeTypeId => {

6
tests/wpt/metadata/dom/nodes/Element-tagName.html.ini
View file

@ -3,9 +3,3 @@
[tagName should be updated when changing ownerDocument]
expected: FAIL
[tagName should be updated when changing ownerDocument (createDocument without prefix)]
expected: FAIL
[tagName should be updated when changing ownerDocument (createDocument with prefix)]
expected: FAIL

6
tests/wpt/metadata/dom/nodes/Node-cloneNode.html.ini
View file

@ -1,11 +1,5 @@
[Node-cloneNode.html]
type: testharness
[Unprefixed HTML element]
expected: FAIL
[Prefixed HTML element]
expected: FAIL
[Prefixed non-HTML element]
expected: FAIL