From 83448b68890fc625be6b4d6f13370fc3bbe58169 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sun, 13 Sep 2020 11:33:13 +0000 Subject: [PATCH] style: Remove -moz-suppressed. Per spec we shouldn't behave differently depending on how we blocked the image/object/etc. This may have made sense in the past when ad blockers were implemented via nsIContentPolicy, but I think nowadays it doesn't make sense, and showing fallback is preferred. There's a couple extra cleanups we can do after this lands, like removing HTMLImageElement.imageBlockingStatus and simplifying a bit that code. But I'll do that in a separate bug. Differential Revision: https://phabricator.services.mozilla.com/D89912 --- components/style/element_state.rs | 2 -- components/style/gecko/non_ts_pseudo_class_list.rs | 1 - components/style/gecko/wrapper.rs | 1 - 3 files changed, 4 deletions(-) diff --git a/components/style/element_state.rs b/components/style/element_state.rs index cdce4d3cc75..ebf6aa42a69 100644 --- a/components/style/element_state.rs +++ b/components/style/element_state.rs @@ -53,8 +53,6 @@ bitflags! { const IN_MOZ_UI_INVALID_STATE = 1 << 13; /// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-broken const IN_BROKEN_STATE = 1 << 14; - /// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-suppressed - const IN_SUPPRESSED_STATE = 1 << 16; /// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-loading const IN_LOADING_STATE = 1 << 17; /// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-handler-blocked diff --git a/components/style/gecko/non_ts_pseudo_class_list.rs b/components/style/gecko/non_ts_pseudo_class_list.rs index 030452a6c0a..77ff53ed3a3 100644 --- a/components/style/gecko/non_ts_pseudo_class_list.rs +++ b/components/style/gecko/non_ts_pseudo_class_list.rs @@ -58,7 +58,6 @@ macro_rules! apply_non_ts_list { ("-moz-focusring", MozFocusRing, IN_FOCUSRING_STATE, _), ("-moz-broken", MozBroken, IN_BROKEN_STATE, _), ("-moz-loading", MozLoading, IN_LOADING_STATE, _), - ("-moz-suppressed", MozSuppressed, IN_SUPPRESSED_STATE, PSEUDO_CLASS_ENABLED_IN_UA_SHEETS_AND_CHROME), ("-moz-has-dir-attr", MozHasDirAttr, IN_HAS_DIR_ATTR_STATE, PSEUDO_CLASS_ENABLED_IN_UA_SHEETS), ("-moz-dir-attr-ltr", MozDirAttrLTR, IN_HAS_DIR_ATTR_LTR_STATE, PSEUDO_CLASS_ENABLED_IN_UA_SHEETS), ("-moz-dir-attr-rtl", MozDirAttrRTL, IN_HAS_DIR_ATTR_RTL_STATE, PSEUDO_CLASS_ENABLED_IN_UA_SHEETS), diff --git a/components/style/gecko/wrapper.rs b/components/style/gecko/wrapper.rs index 8b93ed744c5..932685ea3c1 100644 --- a/components/style/gecko/wrapper.rs +++ b/components/style/gecko/wrapper.rs @@ -2029,7 +2029,6 @@ impl<'le> ::selectors::Element for GeckoElement<'le> { NonTSPseudoClass::Invalid | NonTSPseudoClass::MozUIValid | NonTSPseudoClass::MozBroken | - NonTSPseudoClass::MozSuppressed | NonTSPseudoClass::MozLoading | NonTSPseudoClass::MozHandlerBlocked | NonTSPseudoClass::MozHandlerDisabled |