Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implementation of step 1 activation behavior of htmlanchorelement (fixes #4871)

Browse source 
Fixed issues
This commit is contained in:
Keith Yeung 2015-02-28 17:10:44 +08:00
parent 521f60ec0d
commit 83f56ed061
2 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/script/dom/document.rs
View file

@ -185,6 +185,7 @@ pub trait DocumentHelpers<'a> {
fn window(self) -> Temporary<Window>;
fn encoding_name(self) -> Ref<'a, DOMString>;
fn is_html_document(self) -> bool;
fn is_fully_active(self) -> bool;
fn url(self) -> Url;
fn quirks_mode(self) -> QuirksMode;
fn set_quirks_mode(self, mode: QuirksMode);
@ -224,6 +225,21 @@ impl<'a> DocumentHelpers<'a> for JSRef<'a, Document> {
self.is_html_document
}
// https://html.spec.whatwg.org/multipage/browsers.html#fully-active
fn is_fully_active(self) -> bool {
let window = self.window.root();
let window = window.r();
let browser_context = window.browser_context();
let browser_context = browser_context.as_ref().unwrap();
let active_document = browser_context.active_document().root();
if self.clone() != active_document.r() {
return false;
}
// FIXME: It should also check whether the browser context is top-level or not
true
}
// http://dom.spec.whatwg.org/#dom-document-url
fn url(self) -> Url {
self.url.clone()

7
components/script/dom/htmlanchorelement.rs
View file

@ -113,7 +113,11 @@ impl<'a> Activatable for JSRef<'a, HTMLAnchorElement> {
//https://html.spec.whatwg.org/multipage/semantics.html#the-a-element:activation-behaviour
fn activation_behavior(&self) {
//TODO: Step 1. If the node document is not fully active, abort.
//Step 1. If the node document is not fully active, abort.
let doc = document_from_node(*self).root();
if !doc.r().is_fully_active() {
return;
}
//TODO: Step 2. Check if browsing context is specified and act accordingly.
//TODO: Step 3. Handle <img ismap/>.
//TODO: Step 4. Download the link is `download` attribute is set.
@ -123,7 +127,6 @@ impl<'a> Activatable for JSRef<'a, HTMLAnchorElement> {
Some(ref href) => {
let value = href.r().Value();
debug!("clicked on link to {}", value);
let doc = document_from_node(*self).root();
doc.r().load_anchor_href(value);
}
None => ()