From 84898bc370225350d0717fb57f3b0a4dfa4e7f91 Mon Sep 17 00:00:00 2001 From: Bastien Orivel Date: Sun, 1 Sep 2019 16:35:39 +0200 Subject: [PATCH] Update wpt test to match the new spec where loadend isn't anymore --- tests/wpt/metadata/MANIFEST.json | 2 +- .../the-img-element/invalid-src.html | 22 ++----------------- 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/tests/wpt/metadata/MANIFEST.json b/tests/wpt/metadata/MANIFEST.json index 2843ff8414b..f242d2a480c 100644 --- a/tests/wpt/metadata/MANIFEST.json +++ b/tests/wpt/metadata/MANIFEST.json @@ -640719,7 +640719,7 @@ "support" ], "html/semantics/embedded-content/the-img-element/invalid-src.html": [ - "c3c57ee3c0a05019be4db6650eeefdd53648401e", + "37ea8ce754a3feaa3e305f10899632d231c92363", "testharness" ], "html/semantics/embedded-content/the-img-element/ismap/img-ismap-coordinates-iframe-after.html": [ diff --git a/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/invalid-src.html b/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/invalid-src.html index c3c57ee3c0a..37ea8ce754a 100644 --- a/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/invalid-src.html +++ b/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/invalid-src.html @@ -9,41 +9,23 @@ async_test(function(t) { var img = document.getElementById("brokenurl"); img.src = "http://["; - var errorevent = false; - var loadendevent = false; // The errors should be queued in the event loop, so they should only trigger // after this block of code finishes, not during the img.src setter itself img.addEventListener('error', t.step_func(function() { - assert_false(loadendevent, "loadend should fire after error"); - errorevent = true; - t.step_timeout(t.step_func_done(function() { - assert_true(loadendevent, "loadend event fired"); - }), 0); - })); - img.addEventListener('loadend', t.step_func(function() { - assert_true(errorevent, "error event fired"); - loadendevent = true; + t.step_timeout(t.step_func_done(), 0); })); }, 'src="http://["'); async_test(function(t) { var img = document.getElementById("emptysrc"); img.src = ""; - var loadendevent = false; // Setting src to empty string triggers only error event. // The errors should be queued in the event loop, so they should only trigger // after this block of code finishes, not during the img.src setter itself img.addEventListener('error', t.step_func(function() { - // Queue this check in the event loop to check there is no loadend event - // fired. - t.step_timeout(t.step_func_done(function() { - assert_false(loadendevent, "loadend event should not be fired"); - }), 0); - })); - img.addEventListener('loadend', t.step_func(function() { - loadendevent = true; + t.step_timeout(t.step_func_done(), 0); })); }, 'src=""');