Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-23 05:10:09 +01:00
Code Issues Projects Releases Packages Wiki Activity

compositing: Use webrender_api::ExternalImageSource instead of WebRenderImageSource (#38703)

Browse source 
There is no reason to roll our own type.

Motivation: I need `ExternalImageSource::Invalid`.

Testing: Covered by existing WPT tests, but it's just refactor

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This commit is contained in:
sagudev 2025-08-15 21:39:07 +02:00 • committed by GitHub
parent 18e05d3aab
commit 85588fada0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 20 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/media/lib.rs
View file

@ -10,8 +10,8 @@ mod media_thread;
use std::sync::{Arc, Mutex};
use compositing_traits::{
WebrenderExternalImageApi, WebrenderExternalImageHandlers, WebrenderExternalImageRegistry,
WebrenderImageHandlerType, WebrenderImageSource,
ExternalImageSource, WebrenderExternalImageApi, WebrenderExternalImageHandlers,
WebrenderExternalImageRegistry, WebrenderImageHandlerType,
};
use euclid::default::Size2D;
use ipc_channel::ipc::{IpcReceiver, IpcSender, channel};
@ -214,7 +214,7 @@ impl GLPlayerExternalImages {
}
impl WebrenderExternalImageApi for GLPlayerExternalImages {
fn lock(&mut self, id: u64) -> (WebrenderImageSource, Size2D<i32>) {
fn lock(&mut self, id: u64) -> (ExternalImageSource, Size2D<i32>) {
// The GLPlayerMsgForward::Lock message inserts a fence in the
// GLPlayer command queue.
self.glplayer_channel
@ -228,7 +228,7 @@ impl WebrenderExternalImageApi for GLPlayerExternalImages {
// internal OpenGL subsystem.
//self.webrender_gl
// .wait_sync(gl_sync as gl::GLsync, 0, gl::TIMEOUT_IGNORED);
(WebrenderImageSource::TextureHandle(image_id), size)
(ExternalImageSource::NativeTexture(image_id), size)
}
fn unlock(&mut self, id: u64) {