Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 16:49:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fire slot change events when the slot content changes (#35137)

Browse source 
* Add the onslotchange attribute to ShadowRoot

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Add spec comments to MutationObserver::queue_mutation_observer_microtask

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Add DomRefCell::take

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Add spec comments to notify_mutation_observers

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Fire slotchange events when a slot changes

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* ./mach fmt

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Fix check for when to dispatch slot events

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Potentially fire slot change events in Node::remove

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update WPT expectations

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* ./mach fmt

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Bump stylo

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Move "signal a slot change" into ScriptThread impl

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-01-27 15:13:22 +01:00 • committed by GitHub
parent cd93841ba1
commit 859cc6ab9b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 152 additions and 119 deletions
Download patch file Download diff file Expand all files Collapse all files

23
tests/wpt/meta/shadow-dom/imperative-slot-api-slotchange.html.ini vendored
View file

@ -1,28 +1,7 @@
[imperative-slot-api-slotchange.html]
expected: TIMEOUT
[slotchange event must not fire synchronously.]
expected: TIMEOUT
[slotchange event should not fire when same node is assigned.]
expected: TIMEOUT
[Fire slotchange event when slot's assigned nodes changes.]
expected: TIMEOUT
[Fire slotchange event on previous slot and new slot when node is reassigned.]
expected: TIMEOUT
[Fire slotchange event on node assignment and when assigned node is removed.]
expected: TIMEOUT
[Fire slotchange event when order of assigned nodes changes.]
expected: TIMEOUT
[Fire slotchange event when assigned node is removed.]
expected: TIMEOUT
[Fire slotchange event when removing a slot from Shadows Root that changes its assigned nodes.]
expected: NOTRUN
expected: TIMEOUT
[Fire slotchange event when assign node to nested slot, ensure event bubbles ups.]
expected: TIMEOUT