Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Correct the checks in step 5 of Node::pre_insert.

Browse source
This commit is contained in:
Ms2ger 2014-11-16 12:38:46 +01:00
parent 561fab57d6
commit 859f14f38b
2 changed files with 6 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/script/dom/node.rs
View file

@ -1216,17 +1216,15 @@ impl Node {
// Step 4-5.
match node.type_id() {
TextNodeTypeId => {
match node.parent_node().root() {
Some(ref parent) if parent.is_document() => return Err(HierarchyRequest),
_ => ()
if parent.is_document() {
return Err(HierarchyRequest);
}
}
},
DoctypeNodeTypeId => {
match node.parent_node().root() {
Some(ref parent) if !parent.is_document() => return Err(HierarchyRequest),
_ => ()
if !parent.is_document() {
return Err(HierarchyRequest);
}
}
},
DocumentFragmentNodeTypeId |
ElementNodeTypeId(_) |
ProcessingInstructionNodeTypeId |

11
tests/wpt/metadata/dom/nodes/Node-insertBefore.html.ini
View file

@ -1,11 +0,0 @@
[Node-insertBefore.html]
type: testharness
[If the context node is a document, inserting a document or text node should throw a HierarchyRequestError.]
expected: FAIL
[If the context node is a DocumentFragment, inserting a document or a doctype should throw a HierarchyRequestError.]
expected: FAIL
[If the context node is an element, inserting a document or a doctype should throw a HierarchyRequestError.]
expected: FAIL