Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-08 08:33:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #11533 - heycam:unimpl-setters, r=mbrubeck

Browse source 
Don't complain about unimplemented setters in release builds.

<!-- Please describe your changes on the following line: -->

I found these `println!`s cause a significant performance hit while testing stylo.

r? @mbrubeck

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's just a change to some logging info in geckolib

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11533)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-06-01 14:56:04 -05:00
commit 862ebee6e6
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ports/geckolib/properties.mako.rs
View file

@ -425,10 +425,14 @@ impl ${style_struct.trait_name} for ${style_struct.gecko_struct_name} {
*/ */
% for longhand in stub_longhands: % for longhand in stub_longhands:
fn set_${longhand.ident}(&mut self, _: longhands::${longhand.ident}::computed_value::T) { fn set_${longhand.ident}(&mut self, _: longhands::${longhand.ident}::computed_value::T) {
println!("stylo: Unimplemented property setter: ${longhand.name}"); if cfg!(debug_assertions) {
println!("stylo: Unimplemented property setter: ${longhand.name}");
}
} }
fn copy_${longhand.ident}_from(&mut self, _: &Self) { fn copy_${longhand.ident}_from(&mut self, _: &Self) {
println!("stylo: Unimplemented property setter: ${longhand.name}"); if cfg!(debug_assertions) {
println!("stylo: Unimplemented property setter: ${longhand.name}");
}
} }
% if longhand.need_clone: % if longhand.need_clone:
fn clone_${longhand.ident}(&self) -> longhands::${longhand.ident}::computed_value::T { fn clone_${longhand.ident}(&self) -> longhands::${longhand.ident}::computed_value::T {