Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Update window.open() to return fallible result

Browse source
This commit is contained in:
Utsav Oza 2020-05-04 19:02:38 +05:30
parent 0b05b5ed87
commit 86a5cf75aa
7 changed files with 15 additions and 137 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/webidls/Document.webidl
View file

@ -124,7 +124,7 @@ partial /*sealed*/ interface Document {
[CEReactions, Throws]
Document open(optional DOMString unused1, optional DOMString unused2);
[CEReactions, Throws]
WindowProxy open(USVString url, DOMString name, DOMString features);
WindowProxy? open(USVString url, DOMString name, DOMString features);
[CEReactions, Throws]
void close();
[CEReactions, Throws]

4
components/script/dom/webidls/Window.webidl
View file

@ -40,8 +40,8 @@
// https://github.com/whatwg/html/issues/2115
[Replaceable] readonly attribute WindowProxy? parent;
readonly attribute Element? frameElement;
WindowProxy? open(optional USVString url = "", optional DOMString target = "_blank",
optional DOMString features = "");
[Throws] WindowProxy? open(optional USVString url = "", optional DOMString target = "_blank",
optional DOMString features = "");
//getter WindowProxy (unsigned long index);
// https://github.com/servo/servo/issues/14453