Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-27 23:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

tidy: Add a rule ensuring that // comments are followed by a space in Rust (#38698)

Browse source 
This shows up sometimes in code reviews, so it makes sense that tidy
enforces it. `rustfmt` supports this via comment normalization, but it
does many other things and is still an unstable feature (with bugs).

Testing: There are new tidy tests for this change.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2025-08-18 05:09:09 -07:00 • committed by GitHub
parent 8ca00a3b0c
commit 8743a11ba4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
68 changed files with 169 additions and 152 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/devtools/actors/console.rs
View file

@ -373,7 +373,7 @@ impl Actor for ConsoleActor {
},
"startListeners" => {
//TODO: actually implement listener filters that support starting/stopping
// TODO: actually implement listener filters that support starting/stopping
let listeners = msg.get("listeners").unwrap().as_array().unwrap().to_owned();
let msg = StartedListenersReply {
from: self.name(),
@ -388,7 +388,7 @@ impl Actor for ConsoleActor {
},
"stopListeners" => {
//TODO: actually implement listener filters that support starting/stopping
// TODO: actually implement listener filters that support starting/stopping
let msg = StopListenersReply {
from: self.name(),
stopped_listeners: msg
@ -403,7 +403,7 @@ impl Actor for ConsoleActor {
request.reply_final(&msg)?
},
//TODO: implement autocompletion like onAutocomplete in
// TODO: implement autocompletion like onAutocomplete in
// http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/webconsole.js
"autocomplete" => {
let msg = AutocompleteReply {

6
components/devtools/actors/timeline.rs
View file

@ -126,7 +126,7 @@ impl Serialize for HighResolutionStamp {
}
}
static DEFAULT_TIMELINE_DATA_PULL_TIMEOUT: u64 = 200; //ms
static DEFAULT_TIMELINE_DATA_PULL_TIMEOUT: u64 = 200; // ms
impl TimelineActor {
pub fn new(
@ -209,7 +209,7 @@ impl Actor for TimelineActor {
))
.unwrap();
//TODO: support multiple connections by using root actor's streams instead.
// TODO: support multiple connections by using root actor's streams instead.
*self.stream.borrow_mut() = request.try_clone_stream().ok();
// init memory actor
@ -268,7 +268,7 @@ impl Actor for TimelineActor {
))
.unwrap();
//TODO: move this to the cleanup method.
// TODO: move this to the cleanup method.
if let Some(ref actor_name) = *self.framerate_actor.borrow() {
registry.drop_actor_later(actor_name.clone());
}

2
components/devtools/lib.rs
View file

@ -527,7 +527,7 @@ impl DevtoolsInstance {
let mut actors = self.actors.lock().unwrap();
match self.actor_requests.entry(request_id) {
Occupied(name) => {
//TODO: Delete from map like Firefox does?
// TODO: Delete from map like Firefox does?
name.into_mut().clone()
},
Vacant(entry) => {