Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Script: remove SafeHandleValue::from_raw from DefaultTeeReadRequest (#34995)

Browse source 
* remove SafeHandleValu::efrom_raw from DefaultTeeReadRequest

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>

* remove #[allow(unsafe_code)]

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>

---------

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
This commit is contained in:
Taym Haddadi 2025-01-15 01:05:42 +01:00 • committed by GitHub
parent f5ef8aaed3
commit 87e97cca98
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/defaultteereadrequest.rs
View file

@ -114,7 +114,6 @@ impl DefaultTeeReadRequest {
);
}
/// <https://streams.spec.whatwg.org/#ref-for-read-request-chunk-steps%E2%91%A2>
#[allow(unsafe_code)]
#[allow(clippy::borrowed_box)]
pub(crate) fn chunk_steps(&self, chunk: &Box<Heap<JSVal>>, can_gc: CanGc) {
// Set readAgain to false.
@ -122,17 +121,15 @@ impl DefaultTeeReadRequest {
// Let chunk1 and chunk2 be chunk.
let chunk1 = chunk;
let chunk2 = chunk;
let cx = GlobalScope::get_cx();
rooted!(in(*cx) let chunk1_value = chunk1.get());
rooted!(in(*cx) let chunk2_value = chunk2.get());
// If canceled_2 is false and cloneForBranch2 is true,
if !self.canceled_2.get() && self.clone_for_branch_2.get() {
let cx = GlobalScope::get_cx();
// Let cloneResult be StructuredClone(chunk2).
rooted!(in(*cx) let mut clone_result = UndefinedValue());
let data = structuredclone::write(
cx,
unsafe { SafeHandleValue::from_raw(chunk2.handle()) },
None,
)
.unwrap();
let data = structuredclone::write(cx, chunk2_value.handle(), None).unwrap();
// If cloneResult is an abrupt completion,
if structuredclone::read(&self.stream.global(), data, clone_result.handle_mut())
.is_err()
@ -161,7 +158,7 @@ impl DefaultTeeReadRequest {
if !self.canceled_1.get() {
self.readable_stream_default_controller_enqueue(
&self.branch_1,
unsafe { SafeHandleValue::from_raw(chunk1.handle()) },
chunk1_value.handle(),
can_gc,
);
}
@ -169,7 +166,7 @@ impl DefaultTeeReadRequest {
if !self.canceled_2.get() {
self.readable_stream_default_controller_enqueue(
&self.branch_2,
unsafe { SafeHandleValue::from_raw(chunk2.handle()) },
chunk2_value.handle(),
can_gc,
);
}