From 8823b6351323cce9f85562b833b42c1a369d061f Mon Sep 17 00:00:00 2001 From: Daniel Holbert Date: Sat, 20 May 2023 06:07:48 +0000 Subject: [PATCH] style: Remove code that's flagged as to-be-removed once layout.css.always-repaint-on-unvisited is true If I'm reading the code comment correctly, this is now unreachable code, and hence can & should be removed. Differential Revision: https://phabricator.services.mozilla.com/D178570 --- .../invalidation/element/state_and_attributes.rs | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/components/style/invalidation/element/state_and_attributes.rs b/components/style/invalidation/element/state_and_attributes.rs index 43f7993ad70..9758ae244d9 100644 --- a/components/style/invalidation/element/state_and_attributes.rs +++ b/components/style/invalidation/element/state_and_attributes.rs @@ -225,20 +225,6 @@ where return false; } - // If we the visited state changed, we force a restyle here. Matching - // doesn't depend on the actual visited state at all, so we can't look - // at matching results to decide what to do for this case. - // - // TODO(emilio): This piece of code should be removed when - // layout.css.always-repaint-on-unvisited is true, since we cannot get - // into this situation in that case. - if state_changes.contains(ElementState::VISITED_OR_UNVISITED) { - trace!(" > visitedness change, force subtree restyle"); - // We can't just return here because there may also be attribute - // changes as well that imply additional hints for siblings. - self.data.hint.insert(RestyleHint::restyle_subtree()); - } - let mut classes_removed = SmallVec::<[Atom; 8]>::new(); let mut classes_added = SmallVec::<[Atom; 8]>::new(); if snapshot.class_changed() {