Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix corner clipping typos in layout-2020

Browse source 
inner_radii() had a minus sign that shouldn't be there.

And padding_edge_clip() and content_edge_clip() clearly need to to use
the padding_rect() and content_rect() instead of border_rect.

Tests:
  - css/css-backgrounds/background-clip-padding-box-with-border-radius.html
  - css/css-backgrounds/background-rounded-image-clip.html
This commit is contained in:
Oriol Brufau 2023-04-29 07:24:13 +02:00
parent 7eca93bb7a
commit 88b9ecea3c
3 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/layout_2020/display_list/mod.rs
View file

@ -374,7 +374,7 @@ impl<'a> BuilderForBoxFragment<'a> {
.to_physical(self.fragment.style.writing_mode) .to_physical(self.fragment.style.writing_mode)
.to_webrender(), .to_webrender(),
), ),
self.border_rect, *self.padding_rect(),
builder, builder,
) )
}) })
@ -389,7 +389,7 @@ impl<'a> BuilderForBoxFragment<'a> {
.to_physical(self.fragment.style.writing_mode) .to_physical(self.fragment.style.writing_mode)
.to_webrender(), .to_webrender(),
), ),
self.border_rect, *self.content_rect(),
builder, builder,
) )
}) })
@ -662,7 +662,7 @@ fn image_rendering(ir: style::computed_values::image_rendering::T) -> wr::ImageR
/// Radii for the padding edge or content edge /// Radii for the padding edge or content edge
fn inner_radii(mut radii: wr::BorderRadius, offsets: units::LayoutSideOffsets) -> wr::BorderRadius { fn inner_radii(mut radii: wr::BorderRadius, offsets: units::LayoutSideOffsets) -> wr::BorderRadius {
radii.top_left.width -= -offsets.left; radii.top_left.width -= offsets.left;
radii.bottom_left.width -= offsets.left; radii.bottom_left.width -= offsets.left;
radii.top_right.width -= offsets.right; radii.top_right.width -= offsets.right;

2
tests/wpt/metadata-layout-2020/css/css-backgrounds/background-clip-padding-box-with-border-radius.html.ini
View file

@ -1,2 +0,0 @@
[background-clip-padding-box-with-border-radius.html]
expected: FAIL

2
tests/wpt/metadata-layout-2020/css/css-backgrounds/background-rounded-image-clip.html.ini
View file

@ -1,2 +0,0 @@
[background-rounded-image-clip.html]
expected: FAIL