Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-18 03:45:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement the size presentational hint for <hr> elements (#37211)

Browse source 
This presentational hint either sets the width values of all borders,
removes the bottom border or sets the height of the element, depending
on the context.

This change also implements the corresponding idl attribute (and the
`noshade` attribute, which does nothing in html5)

Testing: Adds new web platform tests

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-06-03 13:22:44 +02:00 • committed by GitHub
parent b4035cc88e
commit 8937542fe3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 204 additions and 251 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/wpt/meta/html/dom/idlharness.https.html.ini vendored
View file

@ -5455,18 +5455,6 @@
[HTMLHeadingElement interface: document.createElement("h1") must inherit property "align" with the proper type]
expected: FAIL
[HTMLHRElement interface: attribute noShade]
expected: FAIL
[HTMLHRElement interface: attribute size]
expected: FAIL
[HTMLHRElement interface: document.createElement("hr") must inherit property "noShade" with the proper type]
expected: FAIL
[HTMLHRElement interface: document.createElement("hr") must inherit property "size" with the proper type]
expected: FAIL
[HTMLOListElement interface: attribute reversed]
expected: FAIL

228
tests/wpt/meta/html/dom/reflection-grouping.html.ini vendored
View file

@ -383,234 +383,6 @@
[hr.tabIndex: IDL set to -2147483648]
expected: FAIL
[hr.noShade: typeof IDL attribute]
expected: FAIL
[hr.noShade: IDL get with DOM attribute unset]
expected: FAIL
[hr.noShade: setAttribute() to ""]
expected: FAIL
[hr.noShade: setAttribute() to " foo "]
expected: FAIL
[hr.noShade: setAttribute() to undefined]
expected: FAIL
[hr.noShade: setAttribute() to null]
expected: FAIL
[hr.noShade: setAttribute() to 7]
expected: FAIL
[hr.noShade: setAttribute() to 1.5]
expected: FAIL
[hr.noShade: setAttribute() to "5%"]
expected: FAIL
[hr.noShade: setAttribute() to "+100"]
expected: FAIL
[hr.noShade: setAttribute() to ".5"]
expected: FAIL
[hr.noShade: setAttribute() to true]
expected: FAIL
[hr.noShade: setAttribute() to false]
expected: FAIL
[hr.noShade: setAttribute() to object "[object Object\]"]
expected: FAIL
[hr.noShade: setAttribute() to NaN]
expected: FAIL
[hr.noShade: setAttribute() to Infinity]
expected: FAIL
[hr.noShade: setAttribute() to -Infinity]
expected: FAIL
[hr.noShade: setAttribute() to "\\0"]
expected: FAIL
[hr.noShade: setAttribute() to object "test-toString"]
expected: FAIL
[hr.noShade: setAttribute() to object "test-valueOf"]
expected: FAIL
[hr.noShade: setAttribute() to "noShade"]
expected: FAIL
[hr.noShade: IDL set to ""]
expected: FAIL
[hr.noShade: IDL set to " foo "]
expected: FAIL
[hr.noShade: IDL set to undefined]
expected: FAIL
[hr.noShade: IDL set to null]
expected: FAIL
[hr.noShade: IDL set to 7]
expected: FAIL
[hr.noShade: IDL set to 1.5]
expected: FAIL
[hr.noShade: IDL set to "5%"]
expected: FAIL
[hr.noShade: IDL set to "+100"]
expected: FAIL
[hr.noShade: IDL set to ".5"]
expected: FAIL
[hr.noShade: IDL set to false]
expected: FAIL
[hr.noShade: IDL set to object "[object Object\]"]
expected: FAIL
[hr.noShade: IDL set to NaN]
expected: FAIL
[hr.noShade: IDL set to Infinity]
expected: FAIL
[hr.noShade: IDL set to -Infinity]
expected: FAIL
[hr.noShade: IDL set to "\\0"]
expected: FAIL
[hr.noShade: IDL set to object "test-toString"]
expected: FAIL
[hr.noShade: IDL set to object "test-valueOf"]
expected: FAIL
[hr.size: typeof IDL attribute]
expected: FAIL
[hr.size: IDL get with DOM attribute unset]
expected: FAIL
[hr.size: setAttribute() to ""]
expected: FAIL
[hr.size: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo "]
expected: FAIL
[hr.size: setAttribute() to undefined]
expected: FAIL
[hr.size: setAttribute() to 7]
expected: FAIL
[hr.size: setAttribute() to 1.5]
expected: FAIL
[hr.size: setAttribute() to "5%"]
expected: FAIL
[hr.size: setAttribute() to "+100"]
expected: FAIL
[hr.size: setAttribute() to ".5"]
expected: FAIL
[hr.size: setAttribute() to true]
expected: FAIL
[hr.size: setAttribute() to false]
expected: FAIL
[hr.size: setAttribute() to object "[object Object\]"]
expected: FAIL
[hr.size: setAttribute() to NaN]
expected: FAIL
[hr.size: setAttribute() to Infinity]
expected: FAIL
[hr.size: setAttribute() to -Infinity]
expected: FAIL
[hr.size: setAttribute() to "\\0"]
expected: FAIL
[hr.size: setAttribute() to null]
expected: FAIL
[hr.size: setAttribute() to object "test-toString"]
expected: FAIL
[hr.size: setAttribute() to object "test-valueOf"]
expected: FAIL
[hr.size: IDL set to ""]
expected: FAIL
[hr.size: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo "]
expected: FAIL
[hr.size: IDL set to undefined]
expected: FAIL
[hr.size: IDL set to 7]
expected: FAIL
[hr.size: IDL set to 1.5]
expected: FAIL
[hr.size: IDL set to "5%"]
expected: FAIL
[hr.size: IDL set to "+100"]
expected: FAIL
[hr.size: IDL set to ".5"]
expected: FAIL
[hr.size: IDL set to true]
expected: FAIL
[hr.size: IDL set to false]
expected: FAIL
[hr.size: IDL set to object "[object Object\]"]
expected: FAIL
[hr.size: IDL set to NaN]
expected: FAIL
[hr.size: IDL set to Infinity]
expected: FAIL
[hr.size: IDL set to -Infinity]
expected: FAIL
[hr.size: IDL set to "\\0"]
expected: FAIL
[hr.size: IDL set to null]
expected: FAIL
[hr.size: IDL set to object "test-toString"]
expected: FAIL
[hr.size: IDL set to object "test-valueOf"]
expected: FAIL
[pre.accessKey: typeof IDL attribute]
expected: FAIL