Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 08:39:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Improve layout of table captions (#32695)

Browse source 
- Instead of treating captions as a `BlockFormattingContext`, treat it as
  a `NonReplacedFormattingContext`, which allows reusing flow layout for
  captions -- fixing some issues with sizing.
- Pass in the proper size of the containing block when laying out,
  fixing margin calculation.
- Follow the unspecified rules about how various size properties on
  captions affect their size.
- Improve linebreaking around atomics, which is tested by
  caption-related tests. This fixes intrinsic size calculation regarding
  soft wrap opportunities around atomic and also makes the code making
  these actual soft wrap opportunities a bit better.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
This commit is contained in:
Martin Robinson 2024-07-08 14:58:38 +02:00 • committed by GitHub
parent 2888193cfe
commit 89944bd330
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
52 changed files with 225 additions and 454 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/css/CSS2/abspos/table-caption-passes-abspos-up-001.html.ini vendored
View file

@ -1,2 +0,0 @@
[table-caption-passes-abspos-up-001.html]
expected: FAIL

2
tests/wpt/meta/css/CSS2/backgrounds/background-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[background-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/backgrounds/background-attachment-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[background-attachment-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/backgrounds/background-color-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[background-color-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/backgrounds/background-image-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[background-image-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/backgrounds/background-position-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[background-position-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/backgrounds/background-repeat-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[background-repeat-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-color-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-color-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-left-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-left-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-left-color-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-left-color-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-left-width-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-left-width-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-right-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-right-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-right-color-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-right-color-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-right-width-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-right-width-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/borders/border-width-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[border-width-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/floats-clear/clear-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[clear-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/linebox/vertical-align-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[vertical-align-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/margin-padding-clear/margin-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[margin-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/margin-padding-clear/margin-left-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[margin-left-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/margin-padding-clear/margin-right-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[margin-right-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/block-formatting-contexts-012.xht.ini vendored
View file

@ -1,2 +0,0 @@
[block-formatting-contexts-012.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/height-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[height-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/max-height-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[max-height-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/max-width-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[max-width-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/min-height-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[min-height-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/min-width-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[min-width-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/width-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[width-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/visuren/clear-applies-to-016.xht.ini vendored
View file

@ -1,2 +0,0 @@
[clear-applies-to-016.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/visuren/clear-applies-to-017.xht.ini vendored
View file

@ -1,2 +0,0 @@
[clear-applies-to-017.xht]
expected: FAIL

3
tests/wpt/meta/css/css-inline/baseline-source/baseline-source-first-001.html.ini vendored
View file

@ -26,8 +26,5 @@
[.target > * 18]
expected: FAIL
[.target > * 19]
expected: FAIL
[.target > * 21]
expected: FAIL

3
tests/wpt/meta/css/css-inline/baseline-source/baseline-source-last-001.html.ini vendored
View file

@ -32,8 +32,5 @@
[.target > * 18]
expected: FAIL
[.target > * 19]
expected: FAIL
[.target > * 21]
expected: FAIL

12
tests/wpt/meta/css/css-tables/tentative/caption.html.ini vendored
View file

@ -1,15 +1,3 @@
[caption.html]
[table 1]
expected: FAIL
[table 2]
expected: FAIL
[table 3]
expected: FAIL
[table 12]
expected: FAIL
[table 13]
expected: FAIL

21
tests/wpt/meta/css/css-tables/tentative/column-widths.html.ini vendored
View file

@ -1,28 +1,10 @@
[column-widths.html]
[table 1]
expected: FAIL
[table 3]
expected: FAIL
[table 5]
expected: FAIL
[table 8]
expected: FAIL
[table 11]
expected: FAIL
[table 13]
expected: FAIL
[table 14]
expected: FAIL
[table 17]
expected: FAIL
[table 19]
expected: FAIL
@ -49,6 +31,3 @@
[table 33]
expected: FAIL
[table 4]
expected: FAIL

3
tests/wpt/meta/css/css-tables/tentative/table-quirks.html.ini vendored
View file

@ -4,3 +4,6 @@
[table 3]
expected: FAIL
[table 6]
expected: FAIL

3
tests/wpt/meta/css/css-tables/tentative/table-width-redistribution-fixed-padding.html.ini vendored
View file

@ -2,9 +2,6 @@
[table 1]
expected: FAIL
[table 2]
expected: FAIL
[table 4]
expected: FAIL

3
tests/wpt/meta/css/css-tables/tentative/table-width-redistribution-fixed.html.ini vendored
View file

@ -5,9 +5,6 @@
[table 4]
expected: FAIL
[table 5]
expected: FAIL
[table 7]
expected: FAIL

30
tests/wpt/meta/css/css-tables/tentative/table-width-redistribution.html.ini vendored
View file

@ -1,43 +1,13 @@
[table-width-redistribution.html]
[table 1]
expected: FAIL
[table 2]
expected: FAIL
[table 3]
expected: FAIL
[table 4]
expected: FAIL
[table 5]
expected: FAIL
[table 6]
expected: FAIL
[table 9]
expected: FAIL
[table 10]
expected: FAIL
[table 11]
expected: FAIL
[table 12]
expected: FAIL
[table 13]
expected: FAIL
[table 14]
expected: FAIL
[table 15]
expected: FAIL
[table 20]
expected: FAIL

3
tests/wpt/meta/css/css-tables/width-distribution/computing-table-width-0.html.ini vendored
View file

@ -1,3 +0,0 @@
[computing-table-width-0.html]
[Width is 100px due to 100px content size of caption]
expected: FAIL

21
tests/wpt/meta/css/cssom-view/table-client-props.html.ini vendored
View file

@ -1,27 +1,6 @@
[table-client-props.html]
[Caption with margin]
expected: FAIL
[Table with separated border]
expected: FAIL
[Table with collapsed border]
expected: FAIL
[Table and wider caption]
expected: FAIL
[Table and narrower caption]
expected: FAIL
[Basic caption]
expected: FAIL
[Caption with padding]
expected: FAIL
[Caption with border]
expected: FAIL
[Bottom caption]
expected: FAIL

21
tests/wpt/meta/css/cssom-view/table-offset-props.html.ini vendored
View file

@ -1,24 +1,3 @@
[table-offset-props.html]
[Caption with margin]
expected: FAIL
[Table with collapsed border]
expected: FAIL
[Table and wider caption]
expected: FAIL
[Table and narrower caption]
expected: FAIL
[Basic caption]
expected: FAIL
[Caption with padding]
expected: FAIL
[Caption with border]
expected: FAIL
[Bottom caption]
expected: FAIL

21
tests/wpt/meta/css/cssom-view/table-scroll-props.html.ini vendored
View file

@ -1,24 +1,3 @@
[table-scroll-props.html]
[Caption with margin]
expected: FAIL
[Table with collapsed border]
expected: FAIL
[Table and wider caption]
expected: FAIL
[Table and narrower caption]
expected: FAIL
[Basic caption]
expected: FAIL
[Caption with padding]
expected: FAIL
[Caption with border]
expected: FAIL
[Bottom caption]
expected: FAIL