Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-13 08:28:19 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #14559 - asajeffrey:script-track-document-and-bc-discarding, r=cbrewster

Browse source 
Implement browsing context discarding

<!-- Please describe your changes on the following line: -->

Implement browsing context discarding (https://html.spec.whatwg.org/multipage/browsers.html#discard-a-document).

* When a pipeline is closed, inform the script thread whether the browsing context is to be discarded.
* In script threads, synchronously discard any similar-origin documents and browsing contexts.
* When a browsing context is discarded, it loses the reference to the active document, but the window keeps it, so we need to move the `Document` pointer from `BrowsingContext` to `Window`.
* Fix the webIDL for Window to make parent and top optional (the spec says they can return null when the browsing context is discarded).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14411
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14559)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2017-01-05 18:20:12 -08:00 • committed by GitHub
commit 8b274f25d3
12 changed files with 196 additions and 160 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/wpt/metadata/MANIFEST.json
View file

@ -45852,6 +45852,12 @@
"path": "cssom/overflow-serialization.html",
"url": "/cssom/overflow-serialization.html"
}
],
"html/semantics/embedded-content/the-iframe-element/iframe-synchronously-discard.html": [
{
"path": "html/semantics/embedded-content/the-iframe-element/iframe-synchronously-discard.html",
"url": "/html/semantics/embedded-content/the-iframe-element/iframe-synchronously-discard.html"
}
]
}
},

32
tests/wpt/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-synchronously-discard.html Normal file
View file

@ -0,0 +1,32 @@
<!doctype html>
<meta charset=utf-8>
<title>IFrame discards are processed synchronously</title>
<body></body>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
async_test(function(t) {
var child = document.createElement("iframe");
child.src = "support/blank.htm?1";
child.onload = t.step_func(function () {
var childWindow = child.contentWindow;
var grandchild = childWindow.document.createElement("iframe");
grandchild.src = "blank.htm?2";
grandchild.onload = t.step_func(function () {
var grandchildWindow = grandchild.contentWindow;
assert_equals(child.contentWindow, childWindow, "child window");
assert_equals(childWindow.parent, window, "child parentage");
assert_equals(grandchild.contentWindow, grandchildWindow, "grandchild window");
assert_equals(grandchildWindow.parent, childWindow, "grandchild parentage");
document.body.removeChild(child);
assert_equals(child.contentWindow, null, "child should be discarded");
assert_equals(childWindow.parent, null, "child window should be discarded");
assert_equals(grandchild.contentWindow, null, "grandchild should be discarded");
assert_equals(grandchildWindow.parent, null, "grandchild window should be discarded");
t.done();
});
childWindow.document.body.appendChild(grandchild);
});
document.body.appendChild(child);
});
</script>