Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add tidy check for unused reftest html files

Browse source 
Refs: https://github.com/servo/servo/issues/7078
This commit is contained in:
Greg Guthe 2015-08-09 22:04:59 -04:00
parent 5c284a546a
commit 8b4b9ed99b
1 changed files with 21 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

24
python/tidy.py
View file

@ -352,13 +352,29 @@ def check_reftest_order(files_to_check):
def get_reftest_names(line): def get_reftest_names(line):
tokens = line.split() tokens = line.split()
if (len(tokens) == 3): if len(tokens) == 3:
return tokens[1] + tokens[2] return tokens[1] + tokens[2]
if (len(tokens) == 4): if len(tokens) == 4:
return tokens[2] + tokens[3] return tokens[2] + tokens[3]
return None return None
def get_html_file_names_from_reftest_list(reftest_dir, file_name):
for line in open(os.path.join(reftest_dir, file_name), "r"):
for token in line.split():
if fnmatch.fnmatch(token, '*.html'):
yield os.path.join(reftest_dir, token)
def check_reftest_html_files_in_basic_list(reftest_dir):
basic_list_files = set(get_html_file_names_from_reftest_list(reftest_dir, "basic" + reftest_filetype))
for file_name in os.listdir(reftest_dir):
file_path = os.path.join(reftest_dir, file_name)
if fnmatch.fnmatch(file_path, '*.html') and file_path not in basic_list_files:
yield (file_path, "", "not found in basic.list")
def scan(): def scan():
sys.path += python_dependencies sys.path += python_dependencies
@ -370,10 +386,12 @@ def scan():
errors = collect_errors_for_files(files_to_check, checking_functions) errors = collect_errors_for_files(files_to_check, checking_functions)
reftest_files = collect_file_names(reftest_directories) reftest_files = collect_file_names(reftest_directories)
reftest_to_check = filter(should_check_reftest, reftest_files) reftest_to_check = filter(should_check_reftest, reftest_files)
r_errors = check_reftest_order(reftest_to_check) r_errors = check_reftest_order(reftest_to_check)
not_found_in_basic_list_errors = check_reftest_html_files_in_basic_list(reftest_directories[0])
errors = list(itertools.chain(errors, r_errors)) errors = list(itertools.chain(errors, r_errors, not_found_in_basic_list_errors))
if errors: if errors:
for error in errors: for error in errors: