Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Make a couple tracing reflect what they actually trace (#38349)

Browse source 
`IndependentFormattingContext::layout` was being traced with name
`IndependentFormattingContext::layout_with_caching`. Better use
`IndependentFormattingContext::layout` instead.

There was also a debug trace with name `NonReplaced cache miss`, but now
this code also applies to replaced boxes, so I'm renaming it to
`IndependentFormattingContext::layout cache miss`.

Testing: Not needed (no behavior change)

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Oriol Brufau 2025-07-30 14:55:25 +02:00 • committed by GitHub
parent a671c50bc9
commit 8c737a6a79
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/layout/formatting_contexts.rs
View file

@ -290,10 +290,7 @@ impl IndependentFormattingContext {
} }
} }
#[servo_tracing::instrument( #[servo_tracing::instrument(name = "IndependentFormattingContext::layout", skip_all)]
name = "IndependentFormattingContext::layout_with_caching",
skip_all
)]
#[allow(clippy::too_many_arguments)] #[allow(clippy::too_many_arguments)]
pub(crate) fn layout( pub(crate) fn layout(
&self, &self,
@ -317,7 +314,7 @@ impl IndependentFormattingContext {
} }
#[cfg(feature = "tracing")] #[cfg(feature = "tracing")]
tracing::debug!( tracing::debug!(
name: "NonReplaced cache miss", name: "IndependentFormattingContext::layout cache miss",
cached = ?cache.containing_block_for_children_size, cached = ?cache.containing_block_for_children_size,
required = ?containing_block_for_children.size, required = ?containing_block_for_children.size,
); );