Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-09 07:25:35 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #14126 - nox:url-port-setter, r=SimonSapin

Browse source 
Fix the URL port setter tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14126)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-11-08 02:39:05 -06:00 • committed by GitHub
commit 8cd5216eef
2 changed files with 8 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/wpt/metadata/url/url-setters.html.ini
View file

@ -6,12 +6,6 @@
[Setting <ssh://me@example.net>.protocol = 'http' Can’t switch from non-special scheme to special. Note: this may change, see https://github.com/whatwg/url/issues/104] [Setting <ssh://me@example.net>.protocol = 'http' Can’t switch from non-special scheme to special. Note: this may change, see https://github.com/whatwg/url/issues/104]
expected: FAIL expected: FAIL
[Setting <http://example.net:8080>.host = 'example.com:' Port number is unchanges if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113]
expected: FAIL
[Setting <http://example.net:8080>.port = '' Port number is unchanged if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113]
expected: FAIL
[Setting <a:/>.pathname = '\x00\x01\t\n\r\x1f !"#$%&'()*+,-./09:;<=>?@AZ[\\\]^_`az{|}~€Éé' UTF-8 percent encoding with the default encode set. Tabs and newlines are removed.] [Setting <a:/>.pathname = '\x00\x01\t\n\r\x1f !"#$%&'()*+,-./09:;<=>?@AZ[\\\]^_`az{|}~€Éé' UTF-8 percent encoding with the default encode set. Tabs and newlines are removed.]
expected: FAIL expected: FAIL

16
tests/wpt/web-platform-tests/url/setters_tests.json
View file

@ -346,14 +346,14 @@
} }
}, },
{ {
"comment": "Port number is unchanges if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113", "comment": "Port number is removed if empty in the new value",
"href": "http://example.net:8080", "href": "http://example.net:8080",
"new_value": "example.com:", "new_value": "example.com:",
"expected": { "expected": {
"href": "http://example.com:8080/", "href": "http://example.com/",
"host": "example.com:8080", "host": "example.com",
"hostname": "example.com", "hostname": "example.com",
"port": "8080" "port": ""
} }
}, },
{ {
@ -761,14 +761,14 @@
} }
}, },
{ {
"comment": "Port number is unchanged if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113", "comment": "Port number is removed if empty in the new value",
"href": "http://example.net:8080", "href": "http://example.net:8080",
"new_value": "", "new_value": "",
"expected": { "expected": {
"href": "http://example.net:8080/", "href": "http://example.net/",
"host": "example.net:8080", "host": "example.net",
"hostname": "example.net", "hostname": "example.net",
"port": "8080" "port": ""
} }
}, },
{ {