Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Don't re-cache structs if we just got them from the cache.

Browse source
This commit is contained in:
Cameron McCormack 2017-09-14 09:10:43 +08:00
parent fd5fe0a8e3
commit 8d3f6b116d
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/style/properties/properties.mako.rs
View file

@ -3529,7 +3529,13 @@ where
StyleAdjuster::new(&mut builder) StyleAdjuster::new(&mut builder)
.adjust(layout_parent_style, flags); .adjust(layout_parent_style, flags);
if builder.modified_reset() { if builder.modified_reset() || !apply_reset {
// If we adjusted any reset structs, we can't cache this ComputedValues.
//
// Also, if we re-used existing reset structs, don't bother caching it
// back again. (Aside from being wasted effort, it will be wrong, since
// context.rule_cache_conditions won't be set appropriately if we
// didn't compute those reset properties.)
context.rule_cache_conditions.borrow_mut() context.rule_cache_conditions.borrow_mut()
.set_uncacheable(); .set_uncacheable();
} }