Auto merge of #9632 - peterjoel:issue_1716, r=KiChjang

Addresses Issue #1716. Indicated part of the document.

Fixes #1716.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9632)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-02-17 15:23:21 +05:30
commit 8d63eff463
11 changed files with 424 additions and 12 deletions

View file

@ -33813,6 +33813,34 @@
"path": "WebIDL/ecmascript-binding/has-instance.html",
"url": "/WebIDL/ecmascript-binding/has-instance.html"
}
],
"html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-percent-encoded.html": [
{
"path": "html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-percent-encoded.html",
"timeout": "long",
"url": "/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-percent-encoded.html"
}
],
"html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-anchor-name.html": [
{
"path": "html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-anchor-name.html",
"timeout": "long",
"url": "/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-anchor-name.html"
}
],
"html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-id-top.html": [
{
"path": "html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-id-top.html",
"timeout": "long",
"url": "/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-id-top.html"
}
],
"html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-top.html": [
{
"path": "html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-top.html",
"timeout": "long",
"url": "/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-top.html"
}
]
}
},

View file

@ -0,0 +1,5 @@
[scroll-frag-percent-encoded.html]
type: testharness
[Fragment Navigation: fragment id should be percent-decoded]
expected: FAIL

View file

@ -0,0 +1,5 @@
[scroll-to-anchor-name.html]
type: testharness
[Fragment Navigation: scroll to anchor name is lower priority than equal id]
expected: FAIL

View file

@ -0,0 +1,5 @@
[scroll-to-id-top.html]
type: testharness
[Fragment Navigation: TOP is a valid element id, which overrides navigating to top of the document]
expected: FAIL

View file

@ -0,0 +1,5 @@
[scroll-to-top.html]
type: testharness
[Fragment Navigation: When fragid is TOP scroll to the top of the document]
expected: FAIL

View file

@ -0,0 +1,59 @@
<!doctype html>
<title>Fragment Navigation: fragment id should be percent-decoded</title>
<meta name=timeout content=long>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<body>
<div></div>
<div id="has two spaces" style="position:absolute; top:200px;"></div>
<div id="escape%20collision" style="position:absolute; top:300px;"></div>
<div id="escape collision" style="position:absolute; top:400px;"></div>
<div id="do%20not%20go%20here" style="position:absolute; top:400px;"></div>
<div style="height:200em;"></div>
<script>
var steps = [{
fragid:'has%20two%20spaces',
handler: function(){
assert_equals( scrollPosition(), 200 );
}
},{
fragid:'escape%20collision',
handler: function(){
assert_equals( scrollPosition(), 400 );
}
},{
fragid:'do%20not%20go%20here',
handler: function(){
// don't move
assert_equals( scrollPosition(), 400 );
}
}];
function scrollPosition(){
return document.documentElement.scrollTop || document.body.scrollTop;
}
function runNextStep(){
if( steps.length > 0 ) {
var step = steps.shift();
var listener = t.step_func( function(){
step.handler();
runNextStep();
});
scrollToFragmentThenDo( step.fragid, listener );
} else {
t.done();
}
}
function scrollToFragmentThenDo( fragid, then ){
location.hash = fragid;
setTimeout( then, 1 );
}
var t = async_test();
t.step( function(){
assert_equals(location.hash, "", "Page must be loaded with no hash");
runNextStep();
})
</script>

View file

@ -0,0 +1,53 @@
<!doctype html>
<title>Fragment Navigation: scroll to anchor name is lower priority than equal id</title>
<meta name=timeout content=long>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<body>
<div></div>
<a name="anchor1" style="position:absolute; top:200px;"></a>
<div id="id-equals-anchor" style="position:absolute; top:300px;"></div>
<a name="id-equals-anchor" style="position:absolute; top:400px;"></a>
<div style="height:200em;"></div>
<script>
var steps = [{
fragid:'anchor1',
handler: function(){
assert_equals( scrollPosition(), 200 );
}
},{
fragid:'id-equals-anchor',
handler: function(){
// id still takes precedence over anchor name
assert_equals( scrollPosition(), 300 );
}
}];
function scrollPosition(){
return document.documentElement.scrollTop || document.body.scrollTop;
}
function runNextStep(){
if( steps.length > 0 ) {
var step = steps.shift();
var listener = t.step_func( function(){
step.handler();
runNextStep();
});
scrollToFragmentThenDo( step.fragid, listener );
} else {
t.done();
}
}
function scrollToFragmentThenDo( fragid, then ){
location.hash = fragid;
setTimeout( then, 1 );
}
var t = async_test();
t.step( function(){
assert_equals(location.hash, "", "Page must be loaded with no hash");
runNextStep();
})
</script>

View file

@ -0,0 +1,51 @@
<!doctype html>
<title>Fragment Navigation: TOP is a valid element id, which overrides navigating to top of the document</title>
<meta name=timeout content=long>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<body>
<div></div>
<div id="Top" style="position:absolute; top:200px;"></div>
<div style="height:200em; position:relative;"></div>
<script>
var steps = [{
fragid:'Top',
handler: function(){
assert_equals( scrollPosition(), 200 );
}
},{
// scroling to top should work when fragid differs from id by case.
fragid:'top',
handler: function(){
assert_equals( scrollPosition(), 0 );
}
}];
function scrollPosition(){
return document.documentElement.scrollTop || document.body.scrollTop;
}
function runNextStep(){
if( steps.length > 0 ) {
var step = steps.shift();
var listener = t.step_func( function(){
step.handler();
runNextStep();
});
scrollToFragmentThenDo( step.fragid, listener );
} else {
t.done();
}
}
function scrollToFragmentThenDo( fragid, then ){
location.hash = fragid;
setTimeout( then, 1 );
}
var t = async_test();
t.step( function(){
assert_equals(location.hash, "", "Page must be loaded with no hash");
runNextStep();
})
</script>

View file

@ -0,0 +1,60 @@
<!doctype html>
<title>Fragment Navigation: When fragid is TOP scroll to the top of the document</title>
<meta name=timeout content=long>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<body>
<div></div>
<div id="not-the-top"></div>
<div style="height:200em"></div>
<script>
var steps = [{
fragid:'not-the-top',
handler: function(){
assert_not_equals( scrollPosition(), 0 );
}
},{
fragid:'top',
handler: function(){
assert_equals( scrollPosition(), 0 );
}
},{
fragid:'not-the-top',
handler: function(){
assert_not_equals( scrollPosition(), 0 );
}
},{
fragid:'TOP',
handler: function(){
assert_equals( scrollPosition(), 0 );
}
}];
function scrollPosition(){
return document.documentElement.scrollTop || document.body.scrollTop;
}
function runNextStep(){
if( steps.length > 0 ) {
var step = steps.shift();
var listener = t.step_func( function(){
step.handler();
runNextStep();
});
scrollToFragmentThenDo( step.fragid, listener );
} else {
t.done();
}
}
function scrollToFragmentThenDo( fragid, then ){
location.hash = fragid;
setTimeout( then, 1 );
}
var t = async_test();
t.step( function(){
assert_equals(location.hash, "", "Page must be loaded with no hash");
runNextStep();
})
</script>