Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove :-servo-case-sensitive-type-attr()

Browse source 
No longer needed now that the case-sensitive flag for attributes selectors is
supported.
Update user-agent CSS sheet to use the standard flag.

Fixes #23227
This commit is contained in:
Ian Moody 2019-04-18 13:34:32 +01:00
parent 04c93c511b
commit 8d7fe68ac3
4 changed files with 10 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/layout_thread/dom_wrapper.rs
View file

@ -817,9 +817,6 @@ impl<'le> ::selectors::Element for ServoLayoutElement<'le> {
_ => true,
}
},
NonTSPseudoClass::ServoCaseSensitiveTypeAttr(ref expected_value) => self
.get_attr_enum(&ns!(), &local_name!("type"))
.map_or(false, |attr| attr == expected_value),
NonTSPseudoClass::ReadOnly => !self
.element
.get_state_for_layout()

4
components/script/dom/element.rs
View file

@ -2889,10 +2889,6 @@ impl<'a> SelectorsElement for DomRoot<Element> {
},
},
NonTSPseudoClass::ServoCaseSensitiveTypeAttr(ref expected_value) => self
.get_attribute(&ns!(), &local_name!("type"))
.map_or(false, |attr| attr.value().eq(expected_value)),
// FIXME(heycam): This is wrong, since extended_filtering accepts
// a string containing commas (separating each language tag in
// a list) but the pseudo-class instead should be parsing and

32
components/style/servo/selector_parser.rs
View file

@ -282,7 +282,6 @@ pub enum NonTSPseudoClass {
ReadWrite,
ReadOnly,
ServoNonZeroBorder,
ServoCaseSensitiveTypeAttr(Atom),
Target,
Visited,
}
@ -302,18 +301,10 @@ impl ToCss for NonTSPseudoClass {
W: fmt::Write,
{
use self::NonTSPseudoClass::*;
match *self {
Lang(ref lang) => {
dest.write_str(":lang(")?;
serialize_identifier(lang, dest)?;
return dest.write_str(")");
},
ServoCaseSensitiveTypeAttr(ref value) => {
dest.write_str(":-servo-case-sensitive-type-attr(")?;
serialize_identifier(value, dest)?;
return dest.write_str(")");
},
_ => {},
if let Lang(ref lang) = *self {
dest.write_str(":lang(")?;
serialize_identifier(lang, dest)?;
return dest.write_str(")");
}
dest.write_str(match *self {
@ -333,7 +324,7 @@ impl ToCss for NonTSPseudoClass {
ServoNonZeroBorder => ":-servo-nonzero-border",
Target => ":target",
Visited => ":visited",
Lang(_) | ServoCaseSensitiveTypeAttr(_) => unreachable!(),
Lang(_) => unreachable!(),
})
}
}
@ -367,12 +358,7 @@ impl NonTSPseudoClass {
PlaceholderShown => ElementState::IN_PLACEHOLDER_SHOWN_STATE,
Target => ElementState::IN_TARGET_STATE,
AnyLink |
Lang(_) |
Link |
Visited |
ServoNonZeroBorder |
ServoCaseSensitiveTypeAttr(_) => ElementState::empty(),
AnyLink | Lang(_) | Link | Visited | ServoNonZeroBorder => ElementState::empty(),
}
}
@ -464,12 +450,6 @@ impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> {
"lang" => {
Lang(parser.expect_ident_or_string()?.as_ref().into())
}
"-servo-case-sensitive-type-attr" => {
if !self.in_user_agent_stylesheet() {
return Err(parser.new_custom_error(SelectorParseErrorKind::UnexpectedIdent(name.clone())));
}
ServoCaseSensitiveTypeAttr(Atom::from(parser.expect_ident()?.as_ref()))
}
_ => return Err(parser.new_custom_error(SelectorParseErrorKind::UnexpectedIdent(name.clone())))
};