Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make writing-mode affect computed display

Browse source 
If a box has a different writing-mode than its containing block, and has a specified display of inline, change the computed display to inline-block.
Also adds the second manual testcase from #15754 as a WPT to assert that the computed display does in fact change.
This commit is contained in:
Benjamin Dahse 2017-03-17 21:41:42 +01:00
parent 0a0fb61b48
commit 8db0fcaa29
4 changed files with 46 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
components/style/properties/properties.mako.rs
View file

@ -2114,6 +2114,21 @@ pub fn apply_declarations<'a, F, I>(device: &Device,
}
}
{
use computed_values::display::T as display;
// CSS writing modes spec (https://drafts.csswg.org/css-writing-modes-3/#block-flow):
//
// If a box has a different writing-mode value than its containing block:
// - If the box has a specified display of inline, its display computes to inline-block. [CSS21]
//
// www-style mail regarding above spec: https://lists.w3.org/Archives/Public/www-style/2017Mar/0045.html
// See https://github.com/servo/servo/issues/15754
if context.layout_parent_style.writing_mode != style.writing_mode &&
style.get_box().clone_display() == display::inline {
style.mutate_box().set_display(display::inline_block);
}
}
{
use computed_values::overflow_x::T as overflow;
use computed_values::overflow_y;