From 8df5e1e74deef20a338664221c025e4edca18acc Mon Sep 17 00:00:00 2001 From: batu_hoang <55729155+longvatrong111@users.noreply.github.com> Date: Sat, 5 Jul 2025 02:09:59 +0800 Subject: [PATCH] webdriver: Properly insert the user agent into the capabilities data structure (#37876) Add user agent into webdriver capabilities. Testing: `/mach test-wpt -r --product servodriver ./tests/wpt/tests/webdriver/tests/classic/new_session/response.py` Signed-off-by: batu_hoang --- components/webdriver_server/lib.rs | 4 ++++ .../meta/webdriver/tests/classic/new_session/response.py.ini | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) delete mode 100644 tests/wpt/meta/webdriver/tests/classic/new_session/response.py.ini diff --git a/components/webdriver_server/lib.rs b/components/webdriver_server/lib.rs index 4710c23dd26..f475b9c7d66 100644 --- a/components/webdriver_server/lib.rs +++ b/components/webdriver_server/lib.rs @@ -678,6 +678,10 @@ impl Handler { "setWindowRect".to_string(), json!(servo_capabilities.set_window_rect), ); + processed.insert( + "userAgent".to_string(), + servo_config::pref!(user_agent).into(), + ); let response = NewSessionResponse::new(session.id.to_string(), Value::Object(processed)); diff --git a/tests/wpt/meta/webdriver/tests/classic/new_session/response.py.ini b/tests/wpt/meta/webdriver/tests/classic/new_session/response.py.ini deleted file mode 100644 index b5c5cede365..00000000000 --- a/tests/wpt/meta/webdriver/tests/classic/new_session/response.py.ini +++ /dev/null @@ -1,3 +0,0 @@ -[response.py] - [test_capability_user_agent] - expected: FAIL