Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Cleaned up python/licenseck.py

Browse source 
- Moved logic into tidy.py
- Removed explicit BSD license exceptions, they are already ignored by
  being inside the codegen directory.
This commit is contained in:
Duncan Keall 2014-09-09 12:16:50 +12:00
parent 6c48066565
commit 8e25e958ab
2 changed files with 21 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

12
python/tidy.py
View file

@ -11,7 +11,7 @@
import os
import fnmatch
import licenseck
from licenseck import licenses
directories_to_check = ["src", "components"]
filetypes_to_check = [".rs", ".rc", ".cpp", ".c", ".h", ".py"]
@ -45,12 +45,14 @@ def should_check(file_name):
return True
def check_license(file_name, contents):
if not licenseck.check_license(file_name, contents):
def check_license(contents):
valid_license = any(contents.startswith(license) for license in licenses)
acknowledged_bad_license = "xfail-license" in contents[:100]
if not (valid_license or acknowledged_bad_license):
yield (1, "incorrect license")
def check_whitespace(file_name, contents):
def check_whitespace(contents):
lines = contents.splitlines(True)
for idx, line in enumerate(lines):
if line[-1] == "\n":
@ -73,7 +75,7 @@ def collect_errors_for_files(files_to_check, checking_functions):
with open(file_name, "r") as fp:
contents = fp.read()
for check in checking_functions:
for error in check(file_name, contents):
for error in check(contents):
# filename, line, message
yield (file_name, error[0], error[1])