From 8e3da8663682c67d36e0c0ee7703a700ddeb75cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sat, 10 Feb 2018 03:38:23 +0100 Subject: [PATCH] style: Tidy Stylist::compute_for_declarations. --- components/style/stylist.rs | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/components/style/stylist.rs b/components/style/stylist.rs index 029adf11fb9..2018468207f 100644 --- a/components/style/stylist.rs +++ b/components/style/stylist.rs @@ -1494,19 +1494,16 @@ impl Stylist { E: TElement, { use font_metrics::get_metrics_provider_for_product; + use std::iter; // FIXME(emilio): Why do we even need the rule node? We should probably // just avoid allocating it and calling `apply_declarations` directly, // maybe... - // - // Also the `vec!` is super-wasteful. - let v = vec![ApplicableDeclarationBlock::from_declarations( - declarations.clone(), - CascadeLevel::StyleAttributeNormal - )]; - let rule_node = - self.rule_tree.insert_ordered_rules(v.into_iter().map(|a| a.order_and_level())); + self.rule_tree.insert_ordered_rules(iter::once(( + StyleSource::Declarations(declarations), + CascadeLevel::StyleAttributeNormal, + ))); // This currently ignores visited styles. It appears to be used for // font styles in via Servo_StyleSet_ResolveForDeclarations.