mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
Enable css-text
explicitly in include.ini (#31502)
* Enable `css-text` explicitly in include.ini The WPT test runner has some strange logic for determining the key's value for a node like `[css]` or `[css-text]`. In this logic, if the node doesn't have an explicit value for a key (here `skip`), then the implicit root node's setting (i.e key/value pair at the top of the file that is not nested under a heading) is used as the default fallback value [1]. Only when the implicit root node doesn't have an explicit value set does the logic starts looking at the current node's parent [2]. In our case, in `include.ini` the default value for `skip` is `true` as that is the first line in the file. Since `[css-text]` doesn't have `skip` set explicitly, the default value of `true` is used even though the parent's value is `false`. [1]:2bafcf9f18/tests/wpt/tests/tools/wptrunner/wptrunner/wptmanifest/backends/conditional.py (L265)
[2]:2bafcf9f18/tests/wpt/tests/tools/wptrunner/wptrunner/manifestinclude.py (L59)
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> * Update text expectations --------- Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
parent
57dbb7a6f6
commit
8f3e1bcabe
11 changed files with 60 additions and 0 deletions
|
@ -94,6 +94,7 @@ skip: true
|
|||
[css-speech]
|
||||
skip: true
|
||||
[css-text]
|
||||
skip: false
|
||||
[i18n]
|
||||
skip: true
|
||||
[css-typed-om]
|
||||
|
|
|
@ -0,0 +1,2 @@
|
|||
[letter-spacing-percent-001.html]
|
||||
expected: FAIL
|
|
@ -2,3 +2,14 @@
|
|||
[Property letter-spacing value 'normal' computes to '0px']
|
||||
expected: FAIL
|
||||
|
||||
[Property letter-spacing value '110%']
|
||||
expected: FAIL
|
||||
|
||||
[Property letter-spacing value '-5%']
|
||||
expected: FAIL
|
||||
|
||||
[Property letter-spacing value 'calc(10% - 20%)']
|
||||
expected: FAIL
|
||||
|
||||
[Property letter-spacing value 'calc(10px - (5% + 10%)']
|
||||
expected: FAIL
|
||||
|
|
|
@ -0,0 +1,12 @@
|
|||
[letter-spacing-valid.html]
|
||||
[e.style['letter-spacing'\] = "120%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['letter-spacing'\] = "-10%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['letter-spacing'\] = "calc(2ch - 30%)" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['letter-spacing'\] = "calc(40% + 50px)" should set the property value]
|
||||
expected: FAIL
|
|
@ -0,0 +1,2 @@
|
|||
[word-spacing-002.html]
|
||||
expected: FAIL
|
|
@ -0,0 +1,2 @@
|
|||
[word-spacing-percent-001.html]
|
||||
expected: FAIL
|
|
@ -0,0 +1,2 @@
|
|||
[letter-spacing-percent-001.html]
|
||||
expected: FAIL
|
|
@ -0,0 +1,12 @@
|
|||
[letter-spacing-computed.html]
|
||||
[Property letter-spacing value '110%']
|
||||
expected: FAIL
|
||||
|
||||
[Property letter-spacing value '-5%']
|
||||
expected: FAIL
|
||||
|
||||
[Property letter-spacing value 'calc(10% - 20%)']
|
||||
expected: FAIL
|
||||
|
||||
[Property letter-spacing value 'calc(10px - (5% + 10%)']
|
||||
expected: FAIL
|
|
@ -0,0 +1,12 @@
|
|||
[letter-spacing-valid.html]
|
||||
[e.style['letter-spacing'\] = "120%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['letter-spacing'\] = "-10%" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['letter-spacing'\] = "calc(2ch - 30%)" should set the property value]
|
||||
expected: FAIL
|
||||
|
||||
[e.style['letter-spacing'\] = "calc(40% + 50px)" should set the property value]
|
||||
expected: FAIL
|
|
@ -0,0 +1,2 @@
|
|||
[word-spacing-002.html]
|
||||
expected: FAIL
|
|
@ -0,0 +1,2 @@
|
|||
[word-spacing-percent-001.html]
|
||||
expected: FAIL
|
Loading…
Add table
Add a link
Reference in a new issue