Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't panic if WebGL thread can't be reached during finalization.

Browse source
This commit is contained in:
Josh Matthews 2019-07-29 10:05:48 -04:00
parent eb4f2d150a
commit 8f5c37c0b5
8 changed files with 78 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/script/dom/webglrenderbuffer.rs
View file

@ -89,7 +89,7 @@ impl WebGLRenderbuffer {
.send_command(WebGLCommand::BindRenderbuffer(target, Some(self.id)));
}
pub fn delete(&self) {
pub fn delete(&self, fallible: bool) {
if !self.is_deleted.get() {
self.is_deleted.set(true);
@ -106,9 +106,13 @@ impl WebGLRenderbuffer {
fb.detach_renderbuffer(self);
}
self.upcast::<WebGLObject>()
.context()
.send_command(WebGLCommand::DeleteRenderbuffer(self.id));
let context = self.upcast::<WebGLObject>().context();
let cmd = WebGLCommand::DeleteRenderbuffer(self.id);
if fallible {
context.send_command_ignored(cmd);
} else {
context.send_command(cmd);
}
}
}
@ -199,6 +203,6 @@ impl WebGLRenderbuffer {
impl Drop for WebGLRenderbuffer {
fn drop(&mut self) {
self.delete();
self.delete(true);
}
}