script: dont unwrap in header set (#32973)

Signed-off-by: tobinio <tobias.frischmann1@gmail.com>

components/script/dom/headers.rs

@@ -214,10 +214,20 @@ impl HeadersMethods for Headers {
         }
         // Step 7
         // https://fetch.spec.whatwg.org/#concept-header-list-set
-        self.header_list.borrow_mut().insert(
+        match HeaderValue::from_bytes(&valid_value) {
-            HeaderName::from_str(&valid_name).unwrap(),
+            Ok(value) => {
-            HeaderValue::from_bytes(&valid_value).unwrap(),
+                self.header_list
-        );
+                    .borrow_mut()
+                    .insert(HeaderName::from_str(&valid_name).unwrap(), value);
+            },
+            Err(_) => {
+                // can't add the header, but we don't need to panic the browser over it
+                warn!(
+                    "Servo thinks \"{:?}\" is a valid HTTP header value but HeaderValue doesn't.",
+                    valid_value
+                );
+            },
+        };
         Ok(())
     }
 }

tests/wpt/meta/fetch/api/headers/headers-normalize.any.js.ini

@@ -1,11 +1,27 @@
 [headers-normalize.any.worker.html]
-  expected: CRASH
+  [Create headers with not normalized values]
+    expected: FAIL
+
+  [Check append method with not normalized values]
+    expected: FAIL
+
+  [Check set method with not normalized values]
+    expected: FAIL
+
 
 [headers-normalize.any.sharedworker.html]
   expected: ERROR
 
 [headers-normalize.any.html]
-  expected: CRASH
+  [Create headers with not normalized values]
+    expected: FAIL
+
+  [Check append method with not normalized values]
+    expected: FAIL
+
+  [Check set method with not normalized values]
+    expected: FAIL
+
 
 [headers-normalize.any.serviceworker.html]
   expected: ERROR