From 8faf6839d3c70e6d783805bfeba398850eb19d0a Mon Sep 17 00:00:00 2001 From: Mukilan Thiyagarajan Date: Mon, 19 Feb 2024 17:34:38 +0530 Subject: [PATCH] install libudev-dev required by gamepad API (#31376) Ubuntu 20.04 does not have libudev-dev causing build failure when compiling libudev-sys, which is in-turn needed by gilrs-core. Similarly, nix build also needs the udev C library. On Ubuntu 22.04, we don't see the build failures since the build dependency 'libgstreamer-plugins-base-1.0-dev' transitively pulls in libudev-dev. Fixes #31373 Signed-off-by: Mukilan Thiyagarajan --- etc/shell.nix | 2 ++ python/servo/platform/linux.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/etc/shell.nix b/etc/shell.nix index d77e66e9135..286af5115d5 100644 --- a/etc/shell.nix +++ b/etc/shell.nix @@ -77,6 +77,8 @@ stdenv.mkDerivation (androidEnvironment // rec { taplo llvmPackages.bintools # provides lld + udev # Needed by libudev-sys for GamePad API. + # Build utilities cmake dbus gcc git pkg-config which llvm perl yasm m4 (python3.withPackages (ps: with ps; [virtualenv pip dbus])) diff --git a/python/servo/platform/linux.py b/python/servo/platform/linux.py index 879e8f45926..8e79ed34391 100644 --- a/python/servo/platform/linux.py +++ b/python/servo/platform/linux.py @@ -35,7 +35,7 @@ APT_PKGS = [ 'libgstrtspserver-1.0-dev', 'gstreamer1.0-tools', 'libges-1.0-dev', - 'libharfbuzz-dev', 'liblzma-dev', 'libunwind-dev', 'libunwind-dev', + 'libharfbuzz-dev', 'liblzma-dev', 'libudev-dev', 'libunwind-dev', 'libvulkan1', 'libx11-dev', 'libxcb-render0-dev', 'libxcb-shape0-dev', 'libxcb-xfixes0-dev', 'libxmu-dev', 'libxmu6', 'libegl1-mesa-dev', 'llvm-dev', 'm4', 'xorg-dev',