From 8fb715847d4c9b3162a1edc412fd588ca474fa12 Mon Sep 17 00:00:00 2001 From: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> Date: Wed, 15 Jan 2025 21:09:27 +0100 Subject: [PATCH] Fix build failure with tracing feature (#35009) * Fix build failure with tracing feature Skip tracing preferences for now to avoid: ``` error[E0277]: `Preferences` doesn't implement `std::fmt::Debug` ``` Signed-off-by: Jonathan Schwender * Fix warning about unused tracing span. The tracing span is "used" when it is dropped, so in that sense it is a false positive. Signed-off-by: Jonathan Schwender --------- Signed-off-by: Jonathan Schwender --- components/script/dom/bindings/settings_stack.rs | 1 + components/servo/lib.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/components/script/dom/bindings/settings_stack.rs b/components/script/dom/bindings/settings_stack.rs index c12c48f3c35..66d408cce2f 100644 --- a/components/script/dom/bindings/settings_stack.rs +++ b/components/script/dom/bindings/settings_stack.rs @@ -43,6 +43,7 @@ pub(crate) fn is_execution_stack_empty() -> bool { pub(crate) struct AutoEntryScript { global: DomRoot, #[cfg(feature = "tracing")] + #[allow(dead_code)] span: tracing::span::EnteredSpan, } diff --git a/components/servo/lib.rs b/components/servo/lib.rs index a7215f372db..b6b38f7e8e9 100644 --- a/components/servo/lib.rs +++ b/components/servo/lib.rs @@ -227,7 +227,7 @@ where #[cfg_attr( feature = "tracing", tracing::instrument( - skip(rendering_context, embedder, window), + skip(preferences, rendering_context, embedder, window), fields(servo_profiling = true), level = "trace", )