From 900eaec3cc8e79a94d219b18576779d9399a4b99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sat, 9 Sep 2017 13:14:19 +0200 Subject: [PATCH] style: Remove the special-case in single_keyword_computed. The other case is pretty much the same. --- components/style/properties/helpers.mako.rs | 40 +++++++++------------ 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/components/style/properties/helpers.mako.rs b/components/style/properties/helpers.mako.rs index 76c78e40e24..ab290abefdc 100644 --- a/components/style/properties/helpers.mako.rs +++ b/components/style/properties/helpers.mako.rs @@ -500,32 +500,26 @@ <%def name="single_keyword(name, values, vector=False, **kwargs)"> <%call expr="single_keyword_computed(name, values, vector, **kwargs)"> - % if not "extra_specified" in kwargs and ("aliases" in kwargs or (("extra_%s_aliases" % product) in kwargs)): - impl ToComputedValue for SpecifiedValue { - type ComputedValue = computed_value::T; + impl ToComputedValue for SpecifiedValue { + type ComputedValue = computed_value::T; - #[inline] - fn to_computed_value(&self, _context: &Context) -> computed_value::T { - match *self { - % for value in data.longhands_by_name[name].keyword.values_for(product): - SpecifiedValue::${to_rust_ident(value)} => computed_value::T::${to_rust_ident(value)}, - % endfor - } - } - #[inline] - fn from_computed_value(computed: &computed_value::T) -> Self { - match *computed { - % for value in data.longhands_by_name[name].keyword.values_for(product): - computed_value::T::${to_rust_ident(value)} => SpecifiedValue::${to_rust_ident(value)}, - % endfor - } + #[inline] + fn to_computed_value(&self, _context: &Context) -> computed_value::T { + match *self { + % for value in data.longhands_by_name[name].keyword.values_for(product): + SpecifiedValue::${to_rust_ident(value)} => computed_value::T::${to_rust_ident(value)}, + % endfor } } - % else: - use values::computed::ComputedValueAsSpecified; - impl ComputedValueAsSpecified for SpecifiedValue {} - % endif - + #[inline] + fn from_computed_value(computed: &computed_value::T) -> Self { + match *computed { + % for value in data.longhands_by_name[name].keyword.values_for(product): + computed_value::T::${to_rust_ident(value)} => SpecifiedValue::${to_rust_ident(value)}, + % endfor + } + } + }