mirror of
https://github.com/servo/servo.git
synced 2025-09-23 05:10:09 +01:00
Auto merge of #24524 - bblanke:consolidate-size-helpers, r=jdm
Make offscreen canvas rendering context use offscreen canvas' size; Consolidate size helpers <!-- Please describe your changes on the following line: --> Addresses issues raised in the review of PR #24518 and includes changes to 17 tests' metadata for those that now PASS. Contains fixes in PR #24518: Updated the offscreen canvas rendering context to use the offscreen canvas' size. This involved upgrading several methods to accept u64 sizes. Additionally, the code in OffscreenCanvas::SetWidth() and OffscreenCanvas::SetHeight() was updated to send CanvasMsg::Recreate to the canvas paint thread. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24465 and fix #24536 <!-- Either: --> - [X] There are tests for these changes – 17 were updated to PASS
This commit is contained in:
commit
905f714bb4
32 changed files with 211 additions and 131 deletions
|
@ -1,4 +1,3 @@
|
|||
[2d.gradient.interpolate.multiple.html]
|
||||
[OffscreenCanvas test: 2d.gradient.interpolate.multiple]
|
||||
expected: FAIL
|
||||
|
||||
expected: PASS
|
||||
|
|
|
@ -1,4 +1,3 @@
|
|||
[2d.gradient.interpolate.multiple.worker.html]
|
||||
[2d]
|
||||
expected: FAIL
|
||||
|
||||
expected: PASS
|
||||
|
|
|
@ -1,4 +0,0 @@
|
|||
[2d.gradient.interpolate.overlap.html]
|
||||
[OffscreenCanvas test: 2d.gradient.interpolate.overlap]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[2d.gradient.interpolate.overlap.worker.html]
|
||||
[2d]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.2dstate.html]
|
||||
[Resetting the canvas state resets 2D state variables]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.2dstate.worker.html]
|
||||
[Resetting the canvas state resets 2D state variables]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.clip.html]
|
||||
[Resetting the canvas state resets the current clip region]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.clip.worker.html]
|
||||
[Resetting the canvas state resets the current clip region]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.different.html]
|
||||
[Changing size resets canvas to transparent black]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.different.worker.html]
|
||||
[Changing size resets canvas to transparent black]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.gradient.html]
|
||||
[Resetting the canvas state does not invalidate any existing gradients]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.gradient.worker.html]
|
||||
[Resetting the canvas state does not invalidate any existing gradients]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.same.html]
|
||||
[Setting size (not changing the value) resets canvas to transparent black]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.same.worker.html]
|
||||
[Setting size (not changing the value) resets canvas to transparent black]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.transform.html]
|
||||
[Resetting the canvas state resets the current transformation matrix]
|
||||
expected: FAIL
|
||||
|
|
@ -1,4 +0,0 @@
|
|||
[initial.reset.transform.worker.html]
|
||||
[Resetting the canvas state resets the current transformation matrix]
|
||||
expected: FAIL
|
||||
|
|
@ -1,6 +1,4 @@
|
|||
[offscreencanvas.resize.html]
|
||||
[Verify that resizing a 2d context resets its state.]
|
||||
expected: FAIL
|
||||
|
||||
[Verify that writing to the width and height attributes of an OffscreenCanvas works when there is a 2d context attached.]
|
||||
expected: FAIL
|
||||
|
@ -8,9 +6,6 @@
|
|||
[Verify that resizing an OffscreenCanvas with a webgl context propagates the new size to its placeholder canvas asynchronously.]
|
||||
expected: FAIL
|
||||
|
||||
[Verify that setting the size of a 2d context to the same size it already had resets its state.]
|
||||
expected: FAIL
|
||||
|
||||
[Verify that resizing an OffscreenCanvas with a 2d context propagates the new size to its placeholder canvas asynchronously.]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -25,4 +20,3 @@
|
|||
|
||||
[Verify that writing to the width or height attribute of a placeholder canvas throws an exception even when not changing the value of the attribute.]
|
||||
expected: FAIL
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue