From 9083d5806143322af0feab399b051406eb1a5980 Mon Sep 17 00:00:00 2001 From: eri Date: Wed, 4 Jun 2025 14:11:53 +0200 Subject: [PATCH] devtools: Fix inspector on Firefox 139 (#37247) Added a `target_type` field so that Firefox 139 is happy with showing the inspector. In the future, this should probably include other `TARGET_TYPES` like watcher and process. Testing: Manually tested the inspector in Firefox 139 (not sure if we have automatic devtools tests now). Fixes: #37242 Signed-off-by: eri --- components/devtools/actors/browsing_context.rs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/components/devtools/actors/browsing_context.rs b/components/devtools/actors/browsing_context.rs index 81a00e82d47..fc5116131a0 100644 --- a/components/devtools/actors/browsing_context.rs +++ b/components/devtools/actors/browsing_context.rs @@ -81,6 +81,13 @@ struct BrowsingContextTraits { watchpoints: bool, } +#[derive(Serialize)] +#[serde(rename_all = "lowercase")] +enum TargetType { + Frame, + // Other target types not implemented yet. +} + #[derive(Serialize)] #[serde(rename_all = "camelCase")] pub struct BrowsingContextActorMsg { @@ -104,6 +111,7 @@ pub struct BrowsingContextActorMsg { reflow_actor: String, style_sheets_actor: String, thread_actor: String, + target_type: TargetType, // Part of the official protocol, but not yet implemented. // animations_actor: String, // changes_actor: String, @@ -302,6 +310,7 @@ impl BrowsingContextActor { reflow_actor: self.reflow.clone(), style_sheets_actor: self.style_sheets.clone(), thread_actor: self.thread.clone(), + target_type: TargetType::Frame, } }