Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-21 15:49:04 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #18092 - cbrewster:ce_domtokenlist, r=jdm

Browse source 
Only run DOMTokenList update steps if token was found

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18092)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2017-08-17 21:00:10 -05:00 • committed by GitHub
commit 90a75d41b7
2 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/domtokenlist.rs
View file

@ -158,9 +158,9 @@ impl DOMTokenListMethods for DOMTokenList {
} else { } else {
atoms.remove(pos); atoms.remove(pos);
} }
}
// Step 5. // Step 5.
self.element.set_atomic_tokenlist_attribute(&self.local_name, atoms); self.element.set_atomic_tokenlist_attribute(&self.local_name, atoms);
}
Ok(()) Ok(())
} }

5
tests/wpt/metadata/custom-elements/reactions/DOMTokenList.html.ini
View file

@ -1,5 +0,0 @@
[DOMTokenList.html]
type: testharness
[replace on DOMTokenList must not enqueue an attributeChanged reaction when the token to replace does not exist in the attribute]
expected: FAIL