Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix panic in embedded-opener-remove-frame (#33122)

Browse source 
Signed-off-by: Taym <haddadi.taym@gmail.com>
This commit is contained in:
Taym Haddadi 2024-08-19 22:05:03 +02:00 • committed by GitHub
parent 32a298f3a2
commit 91adf39de7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/window.rs
View file

@ -713,7 +713,9 @@ impl WindowMethods for Window {
fn SetOpener(&self, cx: JSContext, value: HandleValue) -> ErrorResult { fn SetOpener(&self, cx: JSContext, value: HandleValue) -> ErrorResult {
// Step 1. // Step 1.
if value.is_null() { if value.is_null() {
self.window_proxy().disown(); if let Some(proxy) = self.window_proxy.get() {
proxy.disown();
}
return Ok(()); return Ok(());
} }
// Step 2. // Step 2.

1
tests/wpt/meta/html/browsers/windows/embedded-opener-remove-frame.html.ini vendored
View file

@ -1,5 +1,4 @@
[embedded-opener-remove-frame.html] [embedded-opener-remove-frame.html]
expected: CRASH
[opener of discarded nested browsing context] [opener of discarded nested browsing context]
expected: FAIL expected: FAIL