Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

indexeddb: Implement autoincremented keys and report autoincrementedness properly through DOM interface (#38723)

Browse source 
Autoincrementedness was previously being reported as always false. This
PR makes the state become queried from the backend, as the spec
specifies. Additionally this PR ensures the backend correctly handles an
object store which autoincrements.

Testing: WPT
Fixes: None

---------

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
This commit is contained in:
Ashwin Naren 2025-08-30 20:54:18 -07:00 • committed by GitHub
parent ce35161a6e
commit 91b2ab5458
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 80 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/script/dom/idbobjectstore.rs
View file

@ -46,7 +46,6 @@ pub struct IDBObjectStore {
key_path: Option<KeyPath>,
index_names: DomRoot<DOMStringList>,
transaction: Dom<IDBTransaction>,
auto_increment: bool,
// We store the db name in the object store to be able to find the correct
// store in the idb thread when checking if we have a key generator
@ -79,9 +78,6 @@ impl IDBObjectStore {
index_names: DOMStringList::new(global, Vec::new(), can_gc),
transaction: Dom::from_ref(transaction),
// FIXME:(arihant2math)
auto_increment: false,
db_name,
}
}
@ -240,10 +236,10 @@ impl IDBObjectStore {
}
// Step 8: If key was given, then: convert a value to a key with key
let serialized_key: IndexedDBKeyType;
let serialized_key: Option<IndexedDBKeyType>;
if !key.is_undefined() {
serialized_key = convert_value_to_key(cx, key, None)?;
serialized_key = Some(convert_value_to_key(cx, key, None)?);
} else {
// Step 11: We should use in-line keys instead
if let Some(Ok(kpk)) = self
@ -251,13 +247,12 @@ impl IDBObjectStore {
.as_ref()
.map(|p| extract_key(cx, value, p, None))
{
serialized_key = kpk;
serialized_key = Some(kpk);
} else {
if !self.has_key_generator() {
return Err(Error::Data);
}
// FIXME:(arihant2math)
return Err(Error::NotSupported);
serialized_key = None;
}
}
@ -509,7 +504,6 @@ impl IDBObjectStoreMethods<crate::DomTypeHolder> for IDBObjectStore {
// https://www.w3.org/TR/IndexedDB-2/#dom-idbobjectstore-autoincrement
fn AutoIncrement(&self) -> bool {
// FIXME(arihant2math): This is wrong
self.auto_increment
self.has_key_generator()
}
}