Add lint to ensure substitutions use the full form

Check that any variable substitutions use the full ${VAR} form,
not just $VAR (but don't check for quoting yet).
This commit is contained in:
Aneesh Agrawal 2016-08-04 18:12:54 -04:00
parent 79ef9b4efc
commit 9231ca1c69
10 changed files with 23 additions and 14 deletions

View file

@ -8,8 +8,8 @@ set -o errexit
set -o nounset
set -o pipefail
if [ $# -eq 0 ]; then
echo "Usage: $0 /path/to/gecko/objdir [other-regen.py-flags]"
if [ ${#} -eq 0 ]; then
echo "Usage: ${0} /path/to/gecko/objdir [other-regen.py-flags]"
exit 1
fi
@ -32,4 +32,4 @@ else
LIBCLANG_PATH="$(brew --prefix llvm38)/lib/llvm-3.8/lib"
fi
./regen.py --target all "$@"
./regen.py --target all "${@}"

View file

@ -9,7 +9,7 @@ set -o nounset
set -o pipefail
# Run in the tools directory.
cd "$(dirname $0)"
cd "$(dirname ${0})"
# Setup and build bindgen.
if [ "$(uname)" == "Linux" ]; then
@ -25,8 +25,8 @@ if [ ! -x "$(command -v clang-3.8)" ]; then
exit 1
fi
export LD_LIBRARY_PATH=$LIBCLANG_PATH
export DYLD_LIBRARY_PATH=$LIBCLANG_PATH
export LD_LIBRARY_PATH="${LIBCLANG_PATH}"
export DYLD_LIBRARY_PATH="${LIBCLANG_PATH}"
# Check for multirust
if [ ! -x "$(command -v multirust)" ]; then