Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 14:53:49 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add lint to ensure substitutions use the full form

Browse source 
Check that any variable substitutions use the full ${VAR} form,
not just $VAR (but don't check for quoting yet).
This commit is contained in:
Aneesh Agrawal 2016-08-04 18:12:54 -04:00
parent 79ef9b4efc
commit 9231ca1c69
10 changed files with 23 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
python/tidy/servo_tidy/tidy.py
View file

@ -347,6 +347,13 @@ def check_shell(file_name, lines):
if "`" in stripped:
yield (idx + 1, "script should not use backticks for command substitution")
for dollar in re.finditer('\$', stripped):
next_idx = dollar.end()
if next_idx < len(stripped):
next_char = stripped[next_idx]
if not (next_char == '{' or next_char == '('):
yield(idx + 1, "variable substitutions should use the full \"${VAR}\" form")
def check_rust(file_name, lines):
if not file_name.endswith(".rs") or \