Auto merge of #22411 - jdm:fix-webdriver, r=SimonSapin

Make desktop webdriver WPT harness work

This change allows me to run `./mach test-wpt --product servodriver --no-pause-after-test tests/wpt/mozilla/tests/mozilla/DOMParser.html` successfully again.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22409
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22411)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2018-12-11 13:03:52 -05:00 committed by GitHub
commit 92962de76c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 21 additions and 9 deletions

View file

@ -4034,17 +4034,16 @@ where
/// Send the current frame tree to compositor /// Send the current frame tree to compositor
fn send_frame_tree(&mut self, top_level_browsing_context_id: TopLevelBrowsingContextId) { fn send_frame_tree(&mut self, top_level_browsing_context_id: TopLevelBrowsingContextId) {
self.active_browser_id = Some(top_level_browsing_context_id);
let browsing_context_id = BrowsingContextId::from(top_level_browsing_context_id);
// Note that this function can panic, due to ipc-channel creation failure. // Note that this function can panic, due to ipc-channel creation failure.
// avoiding this panic would require a mechanism for dealing // avoiding this panic would require a mechanism for dealing
// with low-resource scenarios. // with low-resource scenarios.
debug!( let browsing_context_id = BrowsingContextId::from(top_level_browsing_context_id);
"Sending frame tree for browsing context {}.",
browsing_context_id
);
if let Some(frame_tree) = self.browsing_context_to_sendable(browsing_context_id) { if let Some(frame_tree) = self.browsing_context_to_sendable(browsing_context_id) {
debug!(
"Sending frame tree for browsing context {}.",
browsing_context_id
);
self.active_browser_id = Some(top_level_browsing_context_id);
self.compositor_proxy self.compositor_proxy
.send(ToCompositorMsg::SetFrameTree(frame_tree)); .send(ToCompositorMsg::SetFrameTree(frame_tree));
} }

View file

@ -1159,6 +1159,8 @@ impl WebDriverHandler<ServoExtensionRoute> for Handler {
_session: &Option<Session>, _session: &Option<Session>,
msg: WebDriverMessage<ServoExtensionRoute>, msg: WebDriverMessage<ServoExtensionRoute>,
) -> WebDriverResult<WebDriverResponse> { ) -> WebDriverResult<WebDriverResponse> {
info!("{:?}", msg.command);
// Unless we are trying to create a new session, we need to ensure that a // Unless we are trying to create a new session, we need to ensure that a
// session has previously been created // session has previously been created
match msg.command { match msg.command {

View file

@ -14,6 +14,7 @@ mac-rel-wpt1:
- ./mach test-wpt --release --processes 4 --total-chunks 6 --this-chunk 1 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log --always-succeed - ./mach test-wpt --release --processes 4 --total-chunks 6 --this-chunk 1 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log --always-succeed
- ./mach filter-intermittents wpt-errorsummary.log --log-intermittents intermittents.log --log-filteredsummary filtered-wpt-errorsummary.log --tracker-api default --reporter-api default - ./mach filter-intermittents wpt-errorsummary.log --log-intermittents intermittents.log --log-filteredsummary filtered-wpt-errorsummary.log --tracker-api default --reporter-api default
- ./mach test-wpt --release --binary-arg=--multiprocess --processes 8 --log-raw test-wpt-mp.log --log-errorsummary wpt-mp-errorsummary.log eventsource - ./mach test-wpt --release --binary-arg=--multiprocess --processes 8 --log-raw test-wpt-mp.log --log-errorsummary wpt-mp-errorsummary.log eventsource
- ./mach test-wpt --release --product=servodriver --headless tests/wpt/mozilla/tests/mozilla/DOMParser.html tests/wpt/mozilla/tests/css/per_glyph_font_fallback_a.html tests/wpt/mozilla/tests/css/img_simple.html tests/wpt/mozilla/tests/mozilla/secure.https.html
- bash ./etc/ci/lockfile_changed.sh - bash ./etc/ci/lockfile_changed.sh
mac-rel-wpt2: mac-rel-wpt2:
@ -141,6 +142,7 @@ linux-rel-wpt:
- ./mach test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log --always-succeed - ./mach test-wpt --release --processes 24 --total-chunks 2 --this-chunk 1 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log --always-succeed
- ./mach filter-intermittents wpt-errorsummary.log --log-intermittents intermittents.log --log-filteredsummary filtered-wpt-errorsummary.log --tracker-api default --reporter-api default - ./mach filter-intermittents wpt-errorsummary.log --log-intermittents intermittents.log --log-filteredsummary filtered-wpt-errorsummary.log --tracker-api default --reporter-api default
- ./mach test-wpt --release --binary-arg=--multiprocess --processes 24 --log-raw test-wpt-mp.log --log-errorsummary wpt-mp-errorsummary.log eventsource - ./mach test-wpt --release --binary-arg=--multiprocess --processes 24 --log-raw test-wpt-mp.log --log-errorsummary wpt-mp-errorsummary.log eventsource
- ./mach test-wpt --release --product=servodriver --headless tests/wpt/mozilla/tests/mozilla/DOMParser.html tests/wpt/mozilla/tests/css/per_glyph_font_fallback_a.html tests/wpt/mozilla/tests/css/img_simple.html tests/wpt/mozilla/tests/mozilla/secure.https.html
- ./etc/ci/clean_build_artifacts.sh - ./etc/ci/clean_build_artifacts.sh
linux-rel-css: linux-rel-css:

View file

@ -671282,7 +671282,7 @@
"support" "support"
], ],
"tools/wptrunner/wptrunner/browsers/servodriver.py": [ "tools/wptrunner/wptrunner/browsers/servodriver.py": [
"1632f8f539ced2807ea7fa89258f6db9ef4eb47c", "44efb8950b68a593417e49be668148b5daa452f6",
"support" "support"
], ],
"tools/wptrunner/wptrunner/browsers/webkit.py": [ "tools/wptrunner/wptrunner/browsers/webkit.py": [

View file

@ -40,6 +40,7 @@ def browser_kwargs(test_type, run_info_data, config, **kwargs):
"debug_info": kwargs["debug_info"], "debug_info": kwargs["debug_info"],
"server_config": config, "server_config": config,
"user_stylesheets": kwargs.get("user_stylesheets"), "user_stylesheets": kwargs.get("user_stylesheets"),
"headless": kwargs.get("headless"),
} }
@ -75,7 +76,7 @@ class ServoWebDriverBrowser(Browser):
init_timeout = 300 # Large timeout for cases where we're booting an Android emulator init_timeout = 300 # Large timeout for cases where we're booting an Android emulator
def __init__(self, logger, binary, debug_info=None, webdriver_host="127.0.0.1", def __init__(self, logger, binary, debug_info=None, webdriver_host="127.0.0.1",
server_config=None, binary_args=None, user_stylesheets=None): server_config=None, binary_args=None, user_stylesheets=None, headless=None):
Browser.__init__(self, logger) Browser.__init__(self, logger)
self.binary = binary self.binary = binary
self.binary_args = binary_args or [] self.binary_args = binary_args or []
@ -87,6 +88,8 @@ class ServoWebDriverBrowser(Browser):
self.server_ports = server_config.ports if server_config else {} self.server_ports = server_config.ports if server_config else {}
self.command = None self.command = None
self.user_stylesheets = user_stylesheets if user_stylesheets else [] self.user_stylesheets = user_stylesheets if user_stylesheets else []
self.headless = headless if headless else False
self.ca_certificate_path = server_config.ssl_config["ca_cert_path"]
def start(self, **kwargs): def start(self, **kwargs):
self.webdriver_port = get_free_port(4444, exclude=self.used_ports) self.webdriver_port = get_free_port(4444, exclude=self.used_ports)
@ -112,6 +115,12 @@ class ServoWebDriverBrowser(Browser):
self.debug_info self.debug_info
) )
if self.headless:
command += ["--headless"]
if self.ca_certificate_path:
command += ["--certificate-path", self.ca_certificate_path]
for stylesheet in self.user_stylesheets: for stylesheet in self.user_stylesheets:
command += ["--user-stylesheet", stylesheet] command += ["--user-stylesheet", stylesheet]