mirror of
https://github.com/servo/servo.git
synced 2025-08-27 16:18:21 +01:00
Update web-platform-tests to revision 9f01716569ae5dfd79675ea55718e48017d077a8
This commit is contained in:
parent
9b24798390
commit
93a31731d9
117 changed files with 3664 additions and 843 deletions
|
@ -1,28 +1,24 @@
|
|||
# Submitting Tests
|
||||
|
||||
Test submission is via the typical [GitHub workflow][github flow]:
|
||||
Test submission is via the typical [GitHub workflow][github flow]. For detailed
|
||||
guidelines on setup and each of these steps, please refer to the [Github Test
|
||||
Submission](github-intro) documentation.
|
||||
|
||||
* Fork the [GitHub repository][repo] (and make sure you're still relatively in
|
||||
sync with it if you forked a while ago)
|
||||
* Fork the [GitHub repository][repo].
|
||||
|
||||
* Create a branch for your changes. Being a key of effective Git flow, it is
|
||||
strongly recommended that the **topic branch** tradition be followed here,
|
||||
i.e. the branch naming convention is based on the "topic" you will be working
|
||||
on, e.g. `git checkout -b topic-name`
|
||||
* Create a feature branch for your changes.
|
||||
|
||||
* Make your changes
|
||||
* Make your changes.
|
||||
|
||||
* Run the `lint` script in the root of your checkout to detect common
|
||||
mistakes in test submissions. This will also be run after submission
|
||||
and any errors will prevent your PR being accepted. If it detects an
|
||||
error that forms an essential part of your test, edit the list of
|
||||
exceptions stored in `tools/lint/lint.whitelist`.
|
||||
mistakes in test submissions. There is [detailed documentation for the lint
|
||||
tool](lint-tool).
|
||||
|
||||
* Commit your changes.
|
||||
|
||||
* Push your local branch to your GitHub repository.
|
||||
|
||||
* Using the GitHub UI create a Pull Request for your branch.
|
||||
* Using the GitHub UI, create a Pull Request for your branch.
|
||||
|
||||
* When you get review comments, make more commits to your branch to
|
||||
address the comments.
|
||||
|
@ -30,8 +26,9 @@ on, e.g. `git checkout -b topic-name`
|
|||
* Once everything is reviewed and all issues are addressed, your pull
|
||||
request will be automatically merged.
|
||||
|
||||
For detailed guidelines on setup and each of these steps, please refer to the
|
||||
[Github Test Submission](../writing-tests/github-intro) documentation.
|
||||
We can sometimes take a little while to go through pull requests because we
|
||||
have to go through all the tests and ensure that they match the specification
|
||||
correctly. But we look at all of them, and take everything that we can.
|
||||
|
||||
Hop on to the [mailing list][public-test-infra] or [IRC][]
|
||||
([webclient][web irc], join channel `#testing`) if you have an issue. There is
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue