Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 14:53:49 +01:00
Code Issues Projects Releases Packages Wiki Activity

Update StyleSheet.insertRule WebIDL to make index optional.

Browse source 
Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an @import rule to insertRule
leads to "Expected a stylesheet loader for @import"

Fixes #23025
This commit is contained in:
Ian Moody 2019-03-13 17:01:52 +00:00
parent 431423388e
commit 948e169e51
6 changed files with 2 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/webidls/CSSStyleSheet.webidl
View file

@ -7,6 +7,6 @@
interface CSSStyleSheet : StyleSheet {
// readonly attribute CSSRule? ownerRule;
[Throws, SameObject] readonly attribute CSSRuleList cssRules;
[Throws] unsigned long insertRule(DOMString rule, unsigned long index);
[Throws] unsigned long insertRule(DOMString rule, optional unsigned long index = 0);
[Throws] void deleteRule(unsigned long index);
};

10
tests/wpt/metadata/css/cssom/insertRule-charset-no-index.html.ini
View file

@ -1,10 +0,0 @@
[insertRule-charset-no-index.html]
[inserRule with charset and omitted index argument]
expected: FAIL
[insertRule with charset and undefined index argument]
expected: FAIL
[insertRule with charset and omitted index argument]
expected: FAIL

7
tests/wpt/metadata/css/cssom/insertRule-import-no-index.html.ini
View file

@ -1,7 +0,0 @@
[insertRule-import-no-index.html]
[inserRule with import and omitted index argument]
expected: FAIL
[insertRule with import and omitted index argument]
expected: FAIL

12
tests/wpt/metadata/css/cssom/insertRule-namespace-no-index.html.ini
View file

@ -1,13 +1,3 @@
[insertRule-namespace-no-index.html]
[inserRule with namespace and omitted index argument]
expected: FAIL
[inserRule with namespace and omitted index argument should insert import]
expected: FAIL
[insertRule with namespace and omitted index argument]
expected: FAIL
[insertRule with namespace and omitted index argument should insert import]
expected: FAIL
expected: CRASH

10
tests/wpt/metadata/css/cssom/insertRule-no-index.html.ini
View file

@ -1,10 +0,0 @@
[insertRule-no-index.html]
[inserRule with omitted index argument]
expected: FAIL
[insertRule with undefined index argument]
expected: FAIL
[insertRule with omitted index argument]
expected: FAIL

3
tests/wpt/metadata/css/cssom/interfaces.html.ini
View file

@ -243,9 +243,6 @@
[MediaList interface: calling deleteMedium(CSSOMString) on style_element.sheet.media with too few arguments must throw TypeError]
expected: FAIL
[CSSStyleSheet interface: operation insertRule(CSSOMString, unsigned long)]
expected: FAIL
[CSSStyleSheet interface: style_element.sheet must inherit property "ownerRule" with the proper type]
expected: FAIL