From ad1e4475afc521f5701dd73b4d742346516992ca Mon Sep 17 00:00:00 2001 From: ak1t0 Date: Thu, 9 Mar 2017 20:10:24 +0900 Subject: [PATCH] Clean up HTMLImageElement::areas --- components/script/dom/htmlimageelement.rs | 27 +++++++++-------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/components/script/dom/htmlimageelement.rs b/components/script/dom/htmlimageelement.rs index ecf63720845..1062bf48463 100644 --- a/components/script/dom/htmlimageelement.rs +++ b/components/script/dom/htmlimageelement.rs @@ -413,25 +413,18 @@ impl HTMLImageElement { } pub fn areas(&self) -> Option>> { let elem = self.upcast::(); - let usemap_attr; - if elem.has_attribute(&LocalName::from("usemap")) { - usemap_attr = elem.get_string_attribute(&local_name!("usemap")); - } else { - return None; + let usemap_attr = match elem.get_attribute(&ns!(), &local_name!("usemap")) { + Some(attr) => attr, + None => return None, + }; + + let value = usemap_attr.value(); + let (first, last) = value.split_at(1); + + if first != "#" || last.len() == 0 { + return None } - let (first, last) = usemap_attr.split_at(1); - - match first { - "#" => {}, - _ => return None, - }; - - match last.len() { - 0 => return None, - _ => {}, - }; - let map = self.upcast::() .following_siblings() .filter_map(Root::downcast::)